Pepper: Stop using SRPC for irt_open_resource().

ppapi/proxy/nacl_message_scanner.cc

Index: ppapi/proxy/nacl_message_scanner.cc
diff --git a/ppapi/proxy/nacl_message_scanner.cc b/ppapi/proxy/nacl_message_scanner.cc
index e9c477d039ca6ffc0ad4a7d08ae3cfb64b9be5e6..af257623160b02c042de2e0cbeaac4ce37119efa 100644
--- a/ppapi/proxy/nacl_message_scanner.cc
+++ b/ppapi/proxy/nacl_message_scanner.cc
@@ -53,9 +53,11 @@ void WriteHandle(int handle_index,
                  IPC::Message* msg) {
   SerializedHandle::WriteHeader(handle.header(), msg);

[Mark Seaborn, 2014/09/08 16:26:53]

BTW, this has a return valid that isn't checked here.  Would this only fail on
out-of-memory?

[teravest, 2014/09/08 20:25:28]

I inspected SerializedHandle::WriteHeader and found the following underlying
calls to Pickle:
  WriteInt
  WriteUInt32
which, on inspection, appear to always return true.

 
-  // Now write the handle itself in POSIX style.
-  msg->WriteBool(true);  // valid == true
-  msg->WriteInt(handle_index);
+  if (handle.type() != SerializedHandle::INVALID) {

[Mark Seaborn, 2014/09/08 16:26:52]

Where is the corresponding reader for this format?  I can't find what reads the
"valid" field.

[teravest, 2014/09/08 20:25:27]

The valid field is read out here:
https://code.google.com/p/chromium/codesearch#chromium/src/ipc/ipc_message_ut...

I've added a comment to specify where the read side is.

+    // Now write the handle itself in POSIX style.
+    msg->WriteBool(true);  // valid == true
+    msg->WriteInt(handle_index);
+  }
 }
 
 // Define overloads for each kind of message parameter that requires special
@@ -318,6 +320,7 @@ bool NaClMessageScanner::ScanMessage(
     CASE_FOR_MESSAGE(PpapiMsg_PPBAudio_NotifyAudioStreamCreated)
     CASE_FOR_MESSAGE(PpapiMsg_PPPMessaging_HandleMessage)
     CASE_FOR_MESSAGE(PpapiPluginMsg_ResourceReply)
+    CASE_FOR_REPLY(PpapiHostMsg_OpenResource)
     CASE_FOR_REPLY(PpapiHostMsg_PPBGraphics3D_CreateTransferBuffer)
     CASE_FOR_REPLY(PpapiHostMsg_PPBImageData_CreateSimple)
     CASE_FOR_REPLY(PpapiHostMsg_ResourceSyncCall)