Pepper: Stop using SRPC for irt_open_resource().

ppapi/native_client/src/trusted/plugin/service_runtime.cc

Index: ppapi/native_client/src/trusted/plugin/service_runtime.cc
diff --git a/ppapi/native_client/src/trusted/plugin/service_runtime.cc b/ppapi/native_client/src/trusted/plugin/service_runtime.cc
index 7802af30b1f7aa4711af327b0aa42c72c7ab3311..b3d2701f4aef7164283f6ce8af7920e353cc4d75 100644
--- a/ppapi/native_client/src/trusted/plugin/service_runtime.cc
+++ b/ppapi/native_client/src/trusted/plugin/service_runtime.cc
@@ -176,6 +176,10 @@ void PluginReverseInterface::OpenManifestEntry_MainThreadContinuation(
   UNREFERENCED_PARAMETER(err);
   // CallOnMainThread continuations always called with err == PP_OK.
 
+  // This method should only ever be called from the PNaCl translator, as the
+  // IRT is not available there.
+  CHECK(!service_runtime_->main_service_runtime());

[Mark Seaborn, 2014/08/07 04:46:23]

Doesn't this allow any nexe to crash the renderer?  If so, the function should
flag an error instead.

Maybe also add a TODO referencing
https://code.google.com/p/chromium/issues/detail?id=302078 ?

[teravest, 2014/08/07 18:47:02]

Nice catch. I've changed this to log an error here and added a TODO.

[Mark Seaborn, 2014/08/28 21:33:49]

I don't see a TODO here, BTW...

+
   NaClLog(4, "Entered OpenManifestEntry_MainThreadContinuation\n");
 
   // Because p is owned by the callback of this invocation, so it is necessary