Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Unified Diff: components/nacl/renderer/ppb_nacl_private_impl.cc

Issue 418423002: Pepper: Stop using SRPC for irt_open_resource(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fixes for dmichael Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/nacl/renderer/ppb_nacl_private_impl.cc
diff --git a/components/nacl/renderer/ppb_nacl_private_impl.cc b/components/nacl/renderer/ppb_nacl_private_impl.cc
index 5c7b9f980b7700c0f4a599ccce6f61e333b45985..8faf225782b82953ea528de684ca49c5e6817360 100644
--- a/components/nacl/renderer/ppb_nacl_private_impl.cc
+++ b/components/nacl/renderer/ppb_nacl_private_impl.cc
@@ -427,13 +427,11 @@ void LaunchSelLdr(PP_Instance instance,
// Create the manifest service handle as well.
// For security hardening, disable the IPCs for open_resource() when they
- // aren't needed. PNaCl doesn't expose open_resource(), and the new
- // open_resource() IPCs are currently only used for Non-SFI NaCl so far,
- // not SFI NaCl. Note that enable_dyncode_syscalls is true if and only if
- // the plugin is a non-PNaCl plugin.
+ // aren't needed. PNaCl doesn't expose open_resource(). Note that
+ // enable_dyncode_syscalls is true if and only if the plugin is a non-PNaCl
+ // plugin.
if (load_manager &&
enable_dyncode_syscalls &&
- uses_nonsfi_mode &&
IsValidChannelHandle(
launch_result.manifest_service_ipc_channel_handle)) {
scoped_ptr<ManifestServiceChannel> manifest_service_channel(

Powered by Google App Engine
This is Rietveld 408576698