Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Issue 418413003: Remove deprecated ...EXTENSION_READY... from user_script_master.cc (Closed)

Created:
6 years, 4 months ago by limasdf
Modified:
6 years, 4 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove deprecated ...EXTENSION_READY from user_script_master.cc R=rockot@chromium.org BUG=354046 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287365

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -31 lines) Patch
M chrome/browser/extensions/user_script_master.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/extensions/user_script_master.cc View 3 chunks +23 lines, -31 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
limasdf
Hi Rockot. Please take a look when you have time.
6 years, 4 months ago (2014-08-04 08:05:43 UTC) #1
Ken Rockot(use gerrit already)
Woohoo! lgtm
6 years, 4 months ago (2014-08-04 15:17:29 UTC) #2
limasdf
The CQ bit was checked by limasdf@gmail.com
6 years, 4 months ago (2014-08-04 15:18:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/limasdf@gmail.com/418413003/20001
6 years, 4 months ago (2014-08-04 15:19:14 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-04 18:09:27 UTC) #5
Message was sent while issue was closed.
Change committed as 287365

Powered by Google App Engine
This is Rietveld 408576698