Issue 418393003: Identity API: make sure account ID is set correctly after sign in

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 418393003: Identity API: make sure account ID is set correctly after sign in (Closed)

Created:
6 years, 5 months ago by Michael Courage

Modified:
6 years, 5 months ago

Reviewers:
fgorski

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Identity API: make sure account ID is set correctly after sign in Previously login access token requests were always made for the primary account ID of the profile. Starting in r275173, the ID is computed and saved in a member variable. This change makes sure the member is updated after the user signs in, which allows getAuthToken requests that trigger a sign-in to succeed. BUG=396883 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285654

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -0 lines)			Patch
	M	chrome/browser/extensions/api/identity/identity_api.cc	View		1 chunk	+6 lines, -0 lines	0 comments	Download
	M	chrome/browser/extensions/api/identity/identity_apitest.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/courage@chromium.org/418393003/1

6 years, 5 months ago (2014-07-25 18:01:10 UTC) #4

Message was sent while issue was closed.

Change committed as 285654

Expand Messages | Collapse Messages