Issue 418383002: Change Has* and Get*Attributes to return Maybe<*>, indicating possible exceptions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 418383002: Change Has* and GetAttributes to return Maybe<>, indicating possible exceptions. (Closed)

Created:
6 years, 5 months ago by Toon Verwaest

Modified:
6 years, 5 months ago

Reviewers:
Igor Sheludko

CC:
v8-dev, Paweł Hajdan Jr.

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Change Has* and Get*Attributes to return Maybe<*>, indicating possible exceptions. BUG= R=ishell@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22624

Patch Set 1 : #

Total comments: 1

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+463 lines, -315 lines)			Patch
M	include/v8.h	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	src/api.cc	View	7 chunks	+40 lines, -12 lines	0 comments	Download
M	src/contexts.cc	View	1 chunk	+7 lines, -4 lines	0 comments	Download
M	src/i18n.cc	View	6 chunks	+18 lines, -6 lines	0 comments	Download
M	src/isolate.h	View	1 chunk	+10 lines, -7 lines	0 comments	Download
M	src/objects.h	View	8 chunks	+61 lines, -61 lines	0 comments	Download
M	src/objects.cc	View	28 chunks	+139 lines, -118 lines	0 comments	Download
M	src/objects-inl.h	View	4 chunks	+28 lines, -17 lines	1 comment	Download
M	src/runtime.cc	View	20 chunks	+93 lines, -70 lines	0 comments	Download
M	test/cctest/test-heap.cc	View	4 chunks	+54 lines, -18 lines	0 comments	Download
M	test/cctest/test-mark-compact.cc	View	2 chunks	+6 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Igor Sheludko

lgtm https://codereview.chromium.org/418383002/diff/80002/src/objects-inl.h File src/objects-inl.h (right): https://codereview.chromium.org/418383002/diff/80002/src/objects-inl.h#newcode6640 src/objects-inl.h:6640: if (!result.has_value) return Maybe<bool>(); It would probably be ...

6 years, 5 months ago (2014-07-25 18:31:41 UTC) #2

Toon Verwaest

6 years, 5 months ago (2014-07-25 18:32:22 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r22624 (presubmit successful).

Expand Messages | Collapse Messages

Issue 418383002: Change Has* and Get*Attributes to return Maybe<*>, indicating possible exceptions. (Closed)

Description

Patch Set 1 : #

Messages

Issue 418383002: Change Has* and GetAttributes to return Maybe<>, indicating possible exceptions. (Closed)