test_runner: Migrate MockWebMediaStreamCenter to Chromium C++ style.

test_runner: Migrate MockWebMediaStreamCenter to Chromium C++ style.

Changes:
1) Run clang-format through source and header files.
2) Rename data member variables to use unix_hacker_ style.
3) Rename methods to use CamelCase style.
4) Rename file name to mock_web_media_stream_center.

BUG=331299
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286052

[jochen (gone - plz use gerrit), 2014-07-28 09:41:47]

https://codereview.chromium.org/418303002/diff/1/content/shell/renderer/test_...
File content/shell/renderer/test_runner/mock_web_media_stream_center.cc (right):

https://codereview.chromium.org/418303002/diff/1/content/shell/renderer/test_...
content/shell/renderer/test_runner/mock_web_media_stream_center.cc:22: class
NewTrackTask : public WebMethodTask<MockWebMediaStreamCenter> {
nit. this class should be in an anonymous namespace

https://codereview.chromium.org/418303002/diff/1/content/shell/renderer/test_...
content/shell/renderer/test_runner/mock_web_media_stream_center.cc:42: };
nit disallow copy/assign

https://codereview.chromium.org/418303002/diff/1/content/shell/renderer/test_...
content/shell/renderer/test_runner/mock_web_media_stream_center.cc:107: class
MockWebAudioDestinationConsumer
this class should be in an anonymous namespace (and moved to the top)

https://codereview.chromium.org/418303002/diff/1/content/shell/renderer/test_...
content/shell/renderer/test_runner/mock_web_media_stream_center.cc:110: virtual
~MockWebAudioDestinationConsumer() {}
nit. should have a ctor

https://codereview.chromium.org/418303002/diff/1/content/shell/renderer/test_...
content/shell/renderer/test_runner/mock_web_media_stream_center.cc:115: };
nit. disallow copy/assign

https://codereview.chromium.org/418303002/diff/1/content/shell/renderer/test_...
File content/shell/renderer/test_runner/mock_web_media_stream_center.h (right):

https://codereview.chromium.org/418303002/diff/1/content/shell/renderer/test_...
content/shell/renderer/test_runner/mock_web_media_stream_center.h:25:
MockWebMediaStreamCenter(blink::WebMediaStreamCenterClient* client,
should have a virtual dtor

https://codereview.chromium.org/418303002/diff/1/content/shell/renderer/test_...
content/shell/renderer/test_runner/mock_web_media_stream_center.h:29: const
blink::WebMediaStreamTrackSourcesRequest& request) OVERRIDE;
nit. no OVERRIDE on blink API implementations

[Abhishek, 2014-07-28 15:02:31]

Resolved all the comments and re-based with latest code to resolve build error.

PTAL !

https://codereview.chromium.org/418303002/diff/1/content/shell/renderer/test_...
File content/shell/renderer/test_runner/mock_web_media_stream_center.cc (right):

https://codereview.chromium.org/418303002/diff/1/content/shell/renderer/test_...
content/shell/renderer/test_runner/mock_web_media_stream_center.cc:22: class
NewTrackTask : public WebMethodTask<MockWebMediaStreamCenter> {
On 2014/07/28 09:41:47, jochen wrote:
> nit. this class should be in an anonymous namespace

Done.

https://codereview.chromium.org/418303002/diff/1/content/shell/renderer/test_...
content/shell/renderer/test_runner/mock_web_media_stream_center.cc:42: };
On 2014/07/28 09:41:47, jochen wrote:
> nit disallow copy/assign

Done.

https://codereview.chromium.org/418303002/diff/1/content/shell/renderer/test_...
content/shell/renderer/test_runner/mock_web_media_stream_center.cc:107: class
MockWebAudioDestinationConsumer
On 2014/07/28 09:41:47, jochen wrote:
> this class should be in an anonymous namespace (and moved to the top)

Done.

https://codereview.chromium.org/418303002/diff/1/content/shell/renderer/test_...
content/shell/renderer/test_runner/mock_web_media_stream_center.cc:110: virtual
~MockWebAudioDestinationConsumer() {}
On 2014/07/28 09:41:47, jochen wrote:
> nit. should have a ctor

Done.

https://codereview.chromium.org/418303002/diff/1/content/shell/renderer/test_...
content/shell/renderer/test_runner/mock_web_media_stream_center.cc:115: };
On 2014/07/28 09:41:47, jochen wrote:
> nit. disallow copy/assign

Done.

https://codereview.chromium.org/418303002/diff/1/content/shell/renderer/test_...
File content/shell/renderer/test_runner/mock_web_media_stream_center.h (right):

https://codereview.chromium.org/418303002/diff/1/content/shell/renderer/test_...
content/shell/renderer/test_runner/mock_web_media_stream_center.h:25:
MockWebMediaStreamCenter(blink::WebMediaStreamCenterClient* client,
On 2014/07/28 09:41:47, jochen wrote:
> should have a virtual dtor

Done.

https://codereview.chromium.org/418303002/diff/1/content/shell/renderer/test_...
content/shell/renderer/test_runner/mock_web_media_stream_center.h:29: const
blink::WebMediaStreamTrackSourcesRequest& request) OVERRIDE;
On 2014/07/28 09:41:47, jochen wrote:
> nit. no OVERRIDE on blink API implementations

Done.

[jochen (gone - plz use gerrit), 2014-07-28 15:03:33]

lgtm

[Abhishek, 2014-07-28 15:05:28]

The CQ bit was checked by abhishek.a21@samsung.com

[commit-bot: I haz the power, 2014-07-28 15:06:15]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/abhishek.a21@samsung.com/418303002/20001

[commit-bot: I haz the power, 2014-07-28 18:28:51]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/34146)
  android_clang_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  linux_chromium_chromeos_clang_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_clang_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel/...)
  win_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel/...)

[commit-bot: I haz the power, 2014-07-28 18:33:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-28 18:33:20]

Try jobs failed on following builders:
  mac_chromium_rel on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel/...)

[Abhishek, 2014-07-28 20:39:56]

On 2014/07/28 18:33:20, I haz the power (commit-bot) wrote:
> Try jobs failed on following builders:
>   mac_chromium_rel on tryserver.chromium.mac
>
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel/...)

Build bot failed for mac_chromium_rel build.
Updating the patch as per the build bot error logs.

[Abhishek, 2014-07-28 20:41:09]

The CQ bit was checked by abhishek.a21@samsung.com

[commit-bot: I haz the power, 2014-07-28 20:44:27]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/abhishek.a21@samsung.com/418303002/40001

[commit-bot: I haz the power, 2014-07-29 02:43:55]

Change committed as 286052