Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 418293004: Do not fetch the CL description when using git cl status --fast. (Closed)

Created:
6 years, 4 months ago by M-A Ruel
Modified:
6 years, 4 months ago
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Project:
tools
Visibility:
Public.

Description

Do not fetch the CL description when using git cl status --fast. This causes a network I/O, which is not fast. Also this is a non-starter in the case of no network connectivity, causing a crash instead of completing successfully. Until Air Canada provides on-flight internet, this is a non-starter. #firstworldproblem. Also fix git cl presubmit in case of lack of network connectivity. R=stip@chromium.org BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=285911

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M git_cl.py View 3 chunks +10 lines, -3 lines 2 comments Download

Messages

Total messages: 6 (0 generated)
M-A Ruel
6 years, 4 months ago (2014-07-27 01:32:21 UTC) #1
iannucci
lgtm https://codereview.chromium.org/418293004/diff/1/git_cl.py File git_cl.py (right): https://codereview.chromium.org/418293004/diff/1/git_cl.py#newcode1326 git_cl.py:1326: print 'Issue description:' it would be neat to ...
6 years, 4 months ago (2014-07-27 18:05:09 UTC) #2
M-A Ruel
https://codereview.chromium.org/418293004/diff/1/git_cl.py File git_cl.py (right): https://codereview.chromium.org/418293004/diff/1/git_cl.py#newcode1326 git_cl.py:1326: print 'Issue description:' On 2014/07/27 18:05:09, iannucci wrote: > ...
6 years, 4 months ago (2014-07-28 15:35:41 UTC) #3
M-A Ruel
The CQ bit was checked by maruel@chromium.org
6 years, 4 months ago (2014-07-28 15:35:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/418293004/1
6 years, 4 months ago (2014-07-28 15:36:11 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-07-28 15:38:00 UTC) #6
Message was sent while issue was closed.
Change committed as 285911

Powered by Google App Engine
This is Rietveld 408576698