Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(558)

Issue 418293003: Revert of Add a chrome://interstitials page. (Closed)

Created:
6 years, 4 months ago by Will Harris
Modified:
6 years, 4 months ago
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -392 lines) Patch
M chrome/browser/chrome_content_browser_client.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_blocking_page.h View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_blocking_page.cc View 3 chunks +8 lines, -16 lines 0 comments Download
M chrome/browser/ssl/ssl_blocking_page.h View 2 chunks +8 lines, -30 lines 0 comments Download
M chrome/browser/ssl/ssl_blocking_page.cc View 2 chunks +1 line, -39 lines 0 comments Download
M chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc View 2 chunks +0 lines, -3 lines 0 comments Download
D chrome/browser/ui/webui/interstitials/interstitial_ui.h View 1 chunk +0 lines, -29 lines 0 comments Download
D chrome/browser/ui/webui/interstitials/interstitial_ui.cc View 1 chunk +0 lines, -200 lines 0 comments Download
D chrome/browser/ui/webui/interstitials/interstitial_ui_browsertest.cc View 1 chunk +0 lines, -59 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/url_constants.h View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/common/url_constants.cc View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Will Harris
Created Revert of Add a chrome://interstitials page.
6 years, 4 months ago (2014-07-26 19:18:29 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wfh@chromium.org/418293003/1
6 years, 4 months ago (2014-07-26 19:19:13 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-07-26 19:19:14 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 4 months ago (2014-07-26 19:19:15 UTC) #4
viettrungluu
lgtm
6 years, 4 months ago (2014-07-26 19:19:55 UTC) #5
viettrungluu
The CQ bit was checked by viettrungluu@chromium.org
6 years, 4 months ago (2014-07-26 19:20:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wfh@chromium.org/418293003/1
6 years, 4 months ago (2014-07-26 19:20:51 UTC) #7
viettrungluu
The CQ bit was unchecked by viettrungluu@chromium.org
6 years, 4 months ago (2014-07-26 19:24:35 UTC) #8
viettrungluu
The CQ bit was checked by viettrungluu@chromium.org
6 years, 4 months ago (2014-07-26 19:24:41 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wfh@chromium.org/418293003/1
6 years, 4 months ago (2014-07-26 19:25:06 UTC) #10
commit-bot: I haz the power
6 years, 4 months ago (2014-07-26 19:26:42 UTC) #11
Message was sent while issue was closed.
Change committed as 285780

Powered by Google App Engine
This is Rietveld 408576698