content/browser/renderer_host/media/video_capture_controller_unittest.cc - Issue 418283003: "Buttery Smooth" Tab Capture.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/media/video_capture_controller_unittest.cc

Issue 418283003: "Buttery Smooth" Tab Capture. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/media/capture/video_capture_oracle_unittest.cc ('K') | « content/browser/renderer_host/media/video_capture_controller.cc ('k') | content/browser/renderer_host/render_widget_host_view_aura_unittest.cc » ('j') | content/browser/renderer_host/render_widget_host_view_mac.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/media/video_capture_controller_unittest.cc

diff --git a/content/browser/renderer_host/media/video_capture_controller_unittest.cc b/content/browser/renderer_host/media/video_capture_controller_unittest.cc

index 367095fa02ea6410189b57f76c7340c06f9690f3..7cfc634d5743ce60709dcf8c1e7ab74f1b1a85d0 100644

--- a/content/browser/renderer_host/media/video_capture_controller_unittest.cc

+++ b/content/browser/renderer_host/media/video_capture_controller_unittest.cc

@@ -112,7 +112,7 @@ class VideoCaptureControllerTest : public testing::Test {

virtual ~VideoCaptureControllerTest() {}

protected:

- static const int kPoolSize = 3;

+ static const int kPoolSize = 5;

virtual void SetUp() OVERRIDE {

controller_.reset(new VideoCaptureController());

@@ -394,7 +394,7 @@ TEST_F(VideoCaptureControllerTest, NormalCaptureMultipleClients) {

session_1);

Mock::VerifyAndClearExpectations(client_b_.get());

- // Third, fourth, and fifth buffers. Pretend they all arrive at the same time.

+ // Third through seventh buffers. Pretend they all arrive at the same time.

for (int i = 0; i < kPoolSize; i++) {

buffer = device_->ReserveOutputBuffer(media::VideoFrame::I420,

capture_resolution);

@@ -413,7 +413,7 @@ TEST_F(VideoCaptureControllerTest, NormalCaptureMultipleClients) {

ASSERT_FALSE(device_->ReserveOutputBuffer(media::VideoFrame::I420,

capture_resolution));

- // The new client needs to be told of 3 buffers; the old clients only 2.

+ // The new client needs to be told of 5 buffers; the old clients only 4.

EXPECT_CALL(*client_b_, DoBufferCreated(client_b_route_2)).Times(kPoolSize);

EXPECT_CALL(*client_b_, DoBufferReady(client_b_route_2)).Times(kPoolSize);

EXPECT_CALL(*client_a_, DoBufferCreated(client_a_route_1))