content/browser/renderer_host/media/video_capture_controller.h - Issue 418283003: "Buttery Smooth" Tab Capture.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/media/video_capture_controller.h

Issue 418283003: "Buttery Smooth" Tab Capture. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Un-inline some methods, plus REBASE. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/renderer_host/media/video_capture_controller.h

diff --git a/content/browser/renderer_host/media/video_capture_controller.h b/content/browser/renderer_host/media/video_capture_controller.h

index c0c3beda263bd50aaff0a7b66e5b10bf147f3c4f..92ab4e77b47456a4be4cc888211dd8999ac67ced 100644

--- a/content/browser/renderer_host/media/video_capture_controller.h

+++ b/content/browser/renderer_host/media/video_capture_controller.h

@@ -66,7 +66,12 @@ class VideoCaptureBufferPool;

class CONTENT_EXPORT VideoCaptureController {

public:

- VideoCaptureController();

+ // |max_buffers| is the maximum number of video frame buffers in-flight at any

+ // one time. This value should be based on the logical capacity of the

+ // capture pipeline, and not on hardware performance. For example, tab

+ // capture requires more buffers than webcam capture because the pipeline is

+ // longer (it includes read-backs pending in the GPU pipeline).

+ explicit VideoCaptureController(int max_buffers);

virtual ~VideoCaptureController();

base::WeakPtr<VideoCaptureController> GetWeakPtr();