content/browser/media/capture/web_contents_video_capture_device_unittest.cc - Issue 418283003: "Buttery Smooth" Tab Capture.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/media/capture/web_contents_video_capture_device_unittest.cc

Issue 418283003: "Buttery Smooth" Tab Capture. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Un-inline some methods, plus REBASE. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/media/capture/web_contents_video_capture_device.cc ('k') | content/browser/renderer_host/media/video_capture_buffer_pool.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/media/capture/web_contents_video_capture_device_unittest.cc

diff --git a/content/browser/media/capture/web_contents_video_capture_device_unittest.cc b/content/browser/media/capture/web_contents_video_capture_device_unittest.cc

index f9557b66c7f074807939a3ffe56b8c827902fd6a..162df4bd06302580700812603beffa15ca74dddd 100644

--- a/content/browser/media/capture/web_contents_video_capture_device_unittest.cc

+++ b/content/browser/media/capture/web_contents_video_capture_device_unittest.cc

@@ -196,8 +196,8 @@ class CaptureTestView : public TestRenderWidgetHostView {

const base::TimeTicks present_time = base::TimeTicks::Now();

RenderWidgetHostViewFrameSubscriber::DeliverFrameCallback callback;

scoped_refptr<media::VideoFrame> target;

- if (subscriber_ && subscriber_->ShouldCaptureFrame(present_time,

- &target, &callback)) {

+ if (subscriber_ && subscriber_->ShouldCaptureFrame(

+ gfx::Rect(), present_time, &target, &callback)) {

SkColor c = ConvertRgbToYuv(controller_->GetSolidColor());

media::FillYUV(

target.get(), SkColorGetR(c), SkColorGetG(c), SkColorGetB(c));