Issue 418273002: Leverage OnFocus event to let component IME extension know about the current screen type (e.g. logi…

Issue 418273002: Leverage OnFocus event to let component IME extension know about the current screen type (e.g. logi… (Closed)

Created:
6 years, 5 months ago by Shu Chen

Modified:
6 years, 5 months ago

Reviewers:
Nikita (slow), Seigo Nonaka

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Leverage OnFocus event to let component IME extension know about the current screen type (e.g. login, lock, etc.) so that on-screen keyboard won't popup new window/page at login/lock screens. BUG=395621 TEST=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285534

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -0 lines)			Patch
	M	chrome/browser/extensions/api/input_ime/input_ime_api.cc	View	1 2	2 chunks	+18 lines, -0 lines	2 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shuchen@chromium.org/418273002/40001

6 years, 5 months ago (2014-07-25 07:25:19 UTC) #4

Nikita (slow)

https://codereview.chromium.org/418273002/diff/40001/chrome/browser/extensions/api/input_ime/input_ime_api.cc File chrome/browser/extensions/api/input_ime/input_ime_api.cc (right): https://codereview.chromium.org/418273002/diff/40001/chrome/browser/extensions/api/input_ime/input_ime_api.cc#newcode160 chrome/browser/extensions/api/input_ime/input_ime_api.cc:160: } You should add another type here "multi-profiles login". ...

6 years, 5 months ago (2014-07-25 09:23:24 UTC) #6

Shu Chen

6 years, 5 months ago (2014-07-25 09:41:06 UTC) #7

Message was sent while issue was closed.

https://codereview.chromium.org/418273002/diff/40001/chrome/browser/extension...
File chrome/browser/extensions/api/input_ime/input_ime_api.cc (right):

https://codereview.chromium.org/418273002/diff/40001/chrome/browser/extension...
chrome/browser/extensions/api/input_ime/input_ime_api.cc:160: }
On 2014/07/25 09:23:24, Nikita Kostylev wrote:
> You should add another type here "multi-profiles login".
> 
> chromeos::UserAddingScreen::Get()->IsRunning();

Thanks, I will create another cl to support it.

Expand Messages | Collapse Messages