Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1245)

Unified Diff: Tools/GardeningServer/ui/ct-commit-list-tests.html

Issue 418253002: Expose the chromium waterfall in sheriff-o-matic. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: merge to ToT Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Tools/GardeningServer/ui/ct-commit-list.html ('k') | Tools/GardeningServer/ui/ct-commit-tests.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Tools/GardeningServer/ui/ct-commit-list-tests.html
diff --git a/Tools/GardeningServer/ui/ct-commit-list-tests.html b/Tools/GardeningServer/ui/ct-commit-list-tests.html
index ef974a560e59c7d0d1ad0df618a91f41920aa2a7..757473140e6744a24835344aafded560ceaf9414 100644
--- a/Tools/GardeningServer/ui/ct-commit-list-tests.html
+++ b/Tools/GardeningServer/ui/ct-commit-list-tests.html
@@ -13,17 +13,45 @@ found in the LICENSE file.
module("ct-commit-list");
-asyncTest("basic", 2, function() {
+asyncTest("basic", 1, function() {
var list = document.createElement('ct-commit-list');
- list.first = 158545;
- list.last = 158547;
list.commits = new CTCommitLogMock();
- Platform.endOfMicrotask(function() {
+ var blinkCommits = list.commits.commits.blink;
+ var revision;
+ for (revision in blinkCommits)
+ break;
+
+ var numCommits = 2;
+
+ list.first = {blink: revision};
+ list.last = {blink: Number(revision) + numCommits};
+
+ requestAnimationFrame(function() {
+ var commits = list.shadowRoot.querySelectorAll('ct-commit');
+ equal(commits.length, numCommits);
+
+ start();
+ });
+});
+
+asyncTest("backwards", 1, function() {
+ var list = document.createElement('ct-commit-list');
+
+ list.commits = new CTCommitLogMock();
+
+ var blinkCommits = list.commits.commits.blink;
+ var revision;
+ for (revision in blinkCommits)
+ break;
+
+ list.first = {blink: revision};
+ list.last = {blink: Number(revision) - 1};
+
+ requestAnimationFrame(function() {
var commits = list.shadowRoot.querySelectorAll('ct-commit');
- equal(commits.length, 1);
- deepEqual(list._revisions, [158545, 158546, 158547])
+ equal(commits.length, 0);
start();
});
« no previous file with comments | « Tools/GardeningServer/ui/ct-commit-list.html ('k') | Tools/GardeningServer/ui/ct-commit-tests.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698