Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Unified Diff: Tools/GardeningServer/scripts/ui.js

Issue 418253002: Expose the chromium waterfall in sheriff-o-matic. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: merge to ToT Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Tools/GardeningServer/run-unittests.html ('k') | Tools/GardeningServer/scripts/ui_unittests.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Tools/GardeningServer/scripts/ui.js
diff --git a/Tools/GardeningServer/scripts/ui.js b/Tools/GardeningServer/scripts/ui.js
index 5b2701fe5ede208427e0854d0d0d4c43b69ed799..449cbf2945ac3794b5c5d8e285e3bf526602b694 100644
--- a/Tools/GardeningServer/scripts/ui.js
+++ b/Tools/GardeningServer/scripts/ui.js
@@ -29,13 +29,20 @@ var ui = ui || {};
// FIXME: Put this all in a more appropriate place.
+// FIXME: Replace the flakiness dashboard's sense of groups with sheriff-o-matic's
+// sense of trees and get rid of this mapping.
+var treeToDashboardGroup = {
+ blink: '@ToT%20Blink',
+ chromium: '@ToT%20Chromium',
+};
+
ui.displayNameForBuilder = function(builderName)
{
return builderName.replace(/Webkit /i, '');
}
// FIXME: Take a master name argument as well.
-ui.urlForFlakinessDashboard = function(testNames, testType)
+ui.urlForFlakinessDashboard = function(testNames, testType, tree)
{
if (Array.isArray(testNames))
testNames = testNames.join(',');
@@ -45,16 +52,19 @@ ui.urlForFlakinessDashboard = function(testNames, testType)
if (testType == 'webkit_tests')
testType = 'layout-tests';
- return 'http://test-results.appspot.com/dashboards/flakiness_dashboard.html#' +
+ // FIXME: sugarjs's toQueryString makes spaces into pluses instead of %20, which confuses
+ // the flakiness dashboard, which just uses decodeURIComponent.
+ return 'http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=' +
+ treeToDashboardGroup[tree] + '&' +
Object.toQueryString({
tests: testNames,
testType: testType,
});
}
-ui.urlForEmbeddedFlakinessDashboard = function(testNames, testType)
+ui.urlForEmbeddedFlakinessDashboard = function(testNames, testType, tree)
{
- return ui.urlForFlakinessDashboard(testNames, testType) + '&showChrome=false';
+ return ui.urlForFlakinessDashboard(testNames, testType, tree) + '&showChrome=false';
}
})();
« no previous file with comments | « Tools/GardeningServer/run-unittests.html ('k') | Tools/GardeningServer/scripts/ui_unittests.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698