Expose the chromium waterfall in sheriff-o-matic.

Tools/GardeningServer/scripts/ui.js

Index: Tools/GardeningServer/scripts/ui.js
diff --git a/Tools/GardeningServer/scripts/ui.js b/Tools/GardeningServer/scripts/ui.js
index 5b2701fe5ede208427e0854d0d0d4c43b69ed799..449cbf2945ac3794b5c5d8e285e3bf526602b694 100644
--- a/Tools/GardeningServer/scripts/ui.js
+++ b/Tools/GardeningServer/scripts/ui.js
@@ -29,13 +29,20 @@ var ui = ui || {};
 
 // FIXME: Put this all in a more appropriate place.
 
+// FIXME: Replace the flakiness dashboard's sense of groups with sheriff-o-matic's

[eseidel, 2014/07/25 16:40:17]

IMO the flakiness dashboard should just operate in terms of masters.  Or we
should just get rid of masters entirely and have globally unique builder names.

[ojan, 2014/07/26 17:31:50]

The flakiness dashboard at least needs the tree concept here so that we can show
you the right list of builders when we show you the embedded flakiness dashboard
in sheriff-o-matic, e.g. if Foo.Test fails on linux and windows, we want to show
you both builders, but those are on different masters.

Another way we could do that is that the flakiness dashboard could take a list
of masters and sheriff-o-matic would be responsible for passing it the list of
masters.

Globally unique builder names SGTM, but that requires changing a lot on the
buildbot side and enforcing it is difficult.

+// sense of trees and get rid of this mapping.
+var treeToDashboardGroup = {
+    blink: '@ToT%20Blink',
+    chromium: '@ToT%20Chromium',
+};
+
 ui.displayNameForBuilder = function(builderName)
 {
     return builderName.replace(/Webkit /i, '');
 }
 
 // FIXME: Take a master name argument as well.
-ui.urlForFlakinessDashboard = function(testNames, testType)
+ui.urlForFlakinessDashboard = function(testNames, testType, tree)
 {
     if (Array.isArray(testNames))
         testNames = testNames.join(',');
@@ -45,16 +52,19 @@ ui.urlForFlakinessDashboard = function(testNames, testType)
     if (testType == 'webkit_tests')
         testType = 'layout-tests';
 
-    return 'http://test-results.appspot.com/dashboards/flakiness_dashboard.html#' +
+    // FIXME: sugarjs's toQueryString makes spaces into pluses instead of %20, which confuses
+    // the flakiness dashboard, which just uses decodeURIComponent.
+    return 'http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=' +
+        treeToDashboardGroup[tree] + '&' +
         Object.toQueryString({
             tests: testNames,
             testType: testType,
         });
 }
 
-ui.urlForEmbeddedFlakinessDashboard = function(testNames, testType)
+ui.urlForEmbeddedFlakinessDashboard = function(testNames, testType, tree)
 {
-    return ui.urlForFlakinessDashboard(testNames, testType) + '&showChrome=false';
+    return ui.urlForFlakinessDashboard(testNames, testType, tree) + '&showChrome=false';
 }
 
 })();