Expose the chromium waterfall in sheriff-o-matic.

Tools/GardeningServer/ui/ct-failure-analyzer.html

 <!--
 Copyright 2014 The Chromium Authors. All rights reserved.
 Use of this source code is governed by a BSD-style license that can be
 found in the LICENSE file.
 -->
 
 <link rel="import" href="../model/ct-failure.html">
 
 <polymer-element name="ct-failure-analyzer" attributes="failures builderLatestRevisions">
   <script>
     // FIXME: Don't use a polymer component for this. Instead use a Failures model
     // object that knows how to do the XHR and process the data appropriately.
     Polymer({
-      builderLatestRevisions: {},
-      failures: {},
+      builderLatestRevisions: null,
+      failures: null,
+
+      // FIXME: Get this from https://chromium.googlesource.com/chromium/tools/build/+/master/scripts/slave/gatekeeper_trees.json?format=text.
+      _trees: {

[eseidel, 2014/07/25 16:40:17]

Isn't this just as simple as atob(xhr.responseText)?

[ojan, 2014/07/26 17:31:51]

Pretty much. It needs doing the network request, atob and then munging the
response into this format. It's not difficult. I just didn't feel like doing it
as part of this patch. I was also thinking it might make sense to skip pulling
this file again if we've already got the data since the data changes so
infrequently. After waffling on that for a few seconds I decided to just punt
for now and leave it as a FIXME.

+        blink: [
+          "https://build.chromium.org/p/chromium.webkit",
+        ],
+        chromium: [
+          "https://build.chromium.org/p/chromium",
+          "https://build.chromium.org/p/chromium.chrome",
+          "https://build.chromium.org/p/chromium.chromiumos",
+          "https://build.chromium.org/p/chromium.gpu",
+          "https://build.chromium.org/p/chromium.linux",
+          "https://build.chromium.org/p/chromium.mac",
+          "https://build.chromium.org/p/chromium.memory",
+          "https://build.chromium.org/p/chromium.win"
+        ],
+      },
 
       update: function() {
         net.json('http://auto-sheriff.appspot.com/data').then(function(data) {
           // FIXME: Don't special-case the blink master.
           this.builderLatestRevisions = data.latest_revisions['chromium.webkit'];
-          this.failures = [];
+          // FIXME: Make this a model class intead of a dumb object.
+          this.failures = {};
           data.range_groups.forEach(function(group) {
             this._processFailuresForGroup(group, data.alerts);
           }.bind(this));
           // FIXME: Sort this.failures by severity of regression, then by oldestFailingRevision.
         }.bind(this));
       },
 
       _failureComparator: function(a, b) {
         if (a.step > b.step)
           return 1;
         if (a.step < b.step)
           return -1
         if (a.testName > b.testName)
           return 1;
         if (a.testName < b.testName)
           return -1
         return 0;
       },
 
       _processFailuresForGroup: function(group, failures) {
         var failuresByReason = {};
 
+        var masterToTree = {};
+        Object.keys(this._trees, function(tree, masters) {
+          masters.forEach(function(master) {
+            masterToTree[master] = tree;
+          });
+        });
+
         group.failure_keys.forEach(function(failure_key) {
           var failure = failures.find(function(item) { return item.key == failure_key; });
           if (failure.ignored_by.length)
             return;
 
-          // FIXME: Make sheriff-o-matic work for all waterfalls.
-          if (!failure.master_url.endsWith('chromium.webkit'))
-            return;
-
           var reason, failureType;
           if (failure.reason) {
             // FIXME: Store the actual failure type in a different field instead of smashing it into the reason.
             var parts = failure.reason.split(':');
             reason = parts[0];
             failureType = parts[1] || 'FAIL';
           } else {
             reason = 'whole step failed';
             failureType = 'UNKNOWN';
           }
 
           var failureKey = JSON.stringify({
             step: failure.step_name,
             reason: reason,
           });
 
+          var tree = masterToTree[failure.master_url];
+
           // FIXME: Use a model class instead of a dumb object.
           if (!failuresByReason[failureKey])
             failuresByReason[failureKey] = {};
-          // FIXME: If we have multiple builders with the same name across masters in
-          // a failure group, then this will incorrectly overwrite one of the values.
-          failuresByReason[failureKey][failure.builder_name] = {
+          if (!failuresByReason[failureKey][tree])
+            failuresByReason[failureKey][tree] = {};
+          failuresByReason[failureKey][tree][failure.builder_name] = {
             // FIXME: Rename to failureType.
             actual: failureType,
             lastFailingBuild: failure.last_failing_build,
             masterUrl: failure.master_url,
           };
         }.bind(this));
 
-        var groupedFailures = [];
-        Object.keys(failuresByReason, function(failureKey, resultByBuilder) {
+        var groupedFailures = {};
+        Object.keys(failuresByReason, function(failureKey, resultsByTree) {
           var failure = JSON.parse(failureKey);
-          groupedFailures.push(new CTFailure(failure.step, failure.reason, resultByBuilder, group.merged_first_failing, group.merged_last_passing));
+          Object.keys(resultsByTree, function(tree, resultsByBuilder) {
+            if (!groupedFailures[tree])
+              groupedFailures[tree] = [];
+            groupedFailures[tree].push(new CTFailure(failure.step, failure.reason, resultsByBuilder, group.merged_first_failing, group.merged_last_passing));
+          })
         });
 
-        // FIXME: Make this a model class intead of a dumb object.
-        groupedFailures.sort(this._failureComparator);
+        Object.keys(groupedFailures, function(tree, failures) {
+          failures.sort(this._failureComparator);
 
-        if (groupedFailures.length)
-          this.failures.push(groupedFailures);
+          if (!this.failures[tree])
+            this.failures[tree] = [];
+          this.failures[tree].push(failures);
+        }.bind(this));
       },
     });
   </script>
 </polymer-element>