Expose the chromium waterfall in sheriff-o-matic.

Tools/GardeningServer/scripts/ui.js

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 11 matching lines @@
  * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
  * THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 var ui = ui || {};
 
 (function () {
 
 // FIXME: Put this all in a more appropriate place.
 
+// FIXME: Replace the flakiness dashboard's sense of groups with sheriff-o-matic's

[eseidel, 2014/07/25 16:40:17]

IMO the flakiness dashboard should just operate in terms of masters.  Or we
should just get rid of masters entirely and have globally unique builder names.

[ojan, 2014/07/26 17:31:50]

The flakiness dashboard at least needs the tree concept here so that we can show
you the right list of builders when we show you the embedded flakiness dashboard
in sheriff-o-matic, e.g. if Foo.Test fails on linux and windows, we want to show
you both builders, but those are on different masters.

Another way we could do that is that the flakiness dashboard could take a list
of masters and sheriff-o-matic would be responsible for passing it the list of
masters.

Globally unique builder names SGTM, but that requires changing a lot on the
buildbot side and enforcing it is difficult.

+// sense of trees and get rid of this mapping.
+var treeToDashboardGroup = {
+    blink: '@ToT%20Blink',
+    chromium: '@ToT%20Chromium',
+};
+
 ui.displayNameForBuilder = function(builderName)
 {
     return builderName.replace(/Webkit /i, '');
 }
 
 // FIXME: Take a master name argument as well.
-ui.urlForFlakinessDashboard = function(testNames, testType)
+ui.urlForFlakinessDashboard = function(testNames, testType, tree)
 {
     if (Array.isArray(testNames))
         testNames = testNames.join(',');
 
     // FIXME: Remove this once the flakiness dashboard stops having webkit_tests
     // masquerade as layout-tests.
     if (testType == 'webkit_tests')
         testType = 'layout-tests';
 
-    return 'http://test-results.appspot.com/dashboards/flakiness_dashboard.html#' +
+    // FIXME: sugarjs's toQueryString makes spaces into pluses instead of %20, which confuses
+    // the flakiness dashboard, which just uses decodeURIComponent.
+    return 'http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=' +
+        treeToDashboardGroup[tree] + '&' +
         Object.toQueryString({
             tests: testNames,
             testType: testType,
         });
 }
 
-ui.urlForEmbeddedFlakinessDashboard = function(testNames, testType)
+ui.urlForEmbeddedFlakinessDashboard = function(testNames, testType, tree)
 {
-    return ui.urlForFlakinessDashboard(testNames, testType) + '&showChrome=false';
+    return ui.urlForFlakinessDashboard(testNames, testType, tree) + '&showChrome=false';
 }
 
 })();