Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1417)

Unified Diff: sdk/lib/_internal/compiler/implementation/js_emitter/reflection_data_parser.dart

Issue 418223010: Revert "Library functions can never be constructors." (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/compiler/implementation/js_emitter/reflection_data_parser.dart
diff --git a/sdk/lib/_internal/compiler/implementation/js_emitter/reflection_data_parser.dart b/sdk/lib/_internal/compiler/implementation/js_emitter/reflection_data_parser.dart
index 98ff62bb128b22eebeb08e0cbb0a3e2c50a5b5b5..2a05f19afaf092b987118ba4b74b7638442b1a66 100644
--- a/sdk/lib/_internal/compiler/implementation/js_emitter/reflection_data_parser.dart
+++ b/sdk/lib/_internal/compiler/implementation/js_emitter/reflection_data_parser.dart
@@ -27,7 +27,6 @@ jsAst.Expression getReflectionDataParser(String classesCollector,
String reflectionInfoField = r'$reflectionInfo';
String reflectionNameField = r'$reflectionName';
String metadataIndexField = r'$metadataIndex';
- String redirectionTargetNameIndex = r'$redirectionTargetIndex';
String defaultValuesField = namer.defaultValuesField;
String methodsWithOptionalArgumentsField =
@@ -182,14 +181,6 @@ jsAst.Expression getReflectionDataParser(String classesCollector,
}
var mangledNames = isStatic ? init.mangledGlobalNames : init.mangledNames;
var unmangledName = ${readString("array", "unmangledNameIndex")};
- var metadataIndex = unmangledNameIndex + 1;
-
- if (unmangledName.substring(0, 6) == "new-> ") {
- // Redirecting constructor.
- funcs[0].$redirectionTargetNameIndex = metadataIndex;
- metadataIndex++;
- unmangledName = "new " + unmangledName.substring(6);
- }
// The function is either a getter, a setter, or a method.
// If it is a method, it might also have a tear-off closure.
// The unmangledName is the same as the getter-name.
@@ -203,7 +194,7 @@ jsAst.Expression getReflectionDataParser(String classesCollector,
}
mangledNames[name] = reflectionName;
funcs[0].$reflectionNameField = reflectionName;
- funcs[0].$metadataIndexField = metadataIndex;
+ funcs[0].$metadataIndexField = unmangledNameIndex + 1;
if (optionalParameterCount) descriptor[unmangledName + "*"] = funcs[0];
}
}

Powered by Google App Engine
This is Rietveld 408576698