Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Unified Diff: sdk/lib/_internal/compiler/implementation/js_emitter/container_builder.dart

Issue 418223010: Revert "Library functions can never be constructors." (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sdk/lib/_internal/compiler/implementation/js_emitter/js_emitter.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/compiler/implementation/js_emitter/container_builder.dart
diff --git a/sdk/lib/_internal/compiler/implementation/js_emitter/container_builder.dart b/sdk/lib/_internal/compiler/implementation/js_emitter/container_builder.dart
index c2195ea10cefc59833d45d899dd3ee92ec7d9d2d..ebb6ea531dbcf50f146dff5af6b2e760849da6ce 100644
--- a/sdk/lib/_internal/compiler/implementation/js_emitter/container_builder.dart
+++ b/sdk/lib/_internal/compiler/implementation/js_emitter/container_builder.dart
@@ -529,33 +529,17 @@ class ContainerBuilder extends CodeEmitterHelper {
}
if (canBeReflected) {
jsAst.LiteralString reflectionName;
- jsAst.LiteralString redirectionTarget = null;
if (member.isConstructor) {
- ConstructorElement constructor = member;
- // TODO(floitsch): is the call to getReflectionName necessary for its
- // side effect? The variable `reflectionNameString` itself is unused.
String reflectionNameString = task.getReflectionName(member, name);
- if (constructor.isRedirectingFactory) {
- reflectionName =
- new jsAst.LiteralString(
- '"new-> ${Elements.reconstructConstructorName(member)}"');
- ConstructorElement effectiveTarget = constructor.effectiveTarget;
- Element targetClass = effectiveTarget.enclosingClass;
- String constructorName = effectiveTarget.name;
- redirectionTarget = js.string("${namer.getNameOfClass(targetClass)}\$"
- "$constructorName");
- } else {
- reflectionName =
- new jsAst.LiteralString(
- '"new ${Elements.reconstructConstructorName(member)}"');
- }
+ reflectionName =
+ new jsAst.LiteralString(
+ '"new ${Elements.reconstructConstructorName(member)}"');
} else {
reflectionName = js.string(member.name);
}
- expressions.add(reflectionName);
- if (redirectionTarget != null) expressions.add(redirectionTarget);
- expressions.addAll(
- task.metadataEmitter.computeMetadata(member).map(js.number));
+ expressions
+ ..add(reflectionName)
+ ..addAll(task.metadataEmitter.computeMetadata(member).map(js.number));
} else if (isClosure && canBeApplied) {
expressions.add(js.string(member.name));
}
« no previous file with comments | « no previous file | sdk/lib/_internal/compiler/implementation/js_emitter/js_emitter.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698