Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 418223005: Expose the method for getting Tab IDs (Closed)

Created:
6 years, 5 months ago by gone
Modified:
6 years, 5 months ago
CC:
chromium-reviews, David Trainor- moved to gerrit, avayvod+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Expose the method for getting Tab IDs BUG=385485, 396884, 396806 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285655

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/Tab.java View 1 chunk +1 line, -1 line 2 comments Download

Messages

Total messages: 6 (0 generated)
gone
6 years, 5 months ago (2014-07-25 02:45:37 UTC) #1
David Trainor- moved to gerrit
lgtm https://chromiumcodereview.appspot.com/418223005/diff/1/chrome/android/java/src/org/chromium/chrome/browser/Tab.java File chrome/android/java/src/org/chromium/chrome/browser/Tab.java (right): https://chromiumcodereview.appspot.com/418223005/diff/1/chrome/android/java/src/org/chromium/chrome/browser/Tab.java#newcode1108 chrome/android/java/src/org/chromium/chrome/browser/Tab.java:1108: public static int generateValidId(int id) { Do we ...
6 years, 5 months ago (2014-07-25 07:49:41 UTC) #2
gone
The CQ bit was checked by dfalcantara@chromium.org
6 years, 5 months ago (2014-07-25 18:34:12 UTC) #3
gone
https://chromiumcodereview.appspot.com/418223005/diff/1/chrome/android/java/src/org/chromium/chrome/browser/Tab.java File chrome/android/java/src/org/chromium/chrome/browser/Tab.java (right): https://chromiumcodereview.appspot.com/418223005/diff/1/chrome/android/java/src/org/chromium/chrome/browser/Tab.java#newcode1108 chrome/android/java/src/org/chromium/chrome/browser/Tab.java:1108: public static int generateValidId(int id) { On 2014/07/25 07:49:41, ...
6 years, 5 months ago (2014-07-25 18:34:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dfalcantara@chromium.org/418223005/1
6 years, 5 months ago (2014-07-25 18:36:04 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-25 20:07:56 UTC) #6
Message was sent while issue was closed.
Change committed as 285655

Powered by Google App Engine
This is Rietveld 408576698