Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 418223004: Use tighter typing in editing/ (Closed)

Created:
6 years, 5 months ago by Inactive
Modified:
6 years, 4 months ago
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

Use tighter typing in editing/ Use tighter typing in editing/ to increase code readability. This CL focuses on ApplyStyleCommand. R=leviw@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178955

Patch Set 1 #

Patch Set 2 : Clean up #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -64 lines) Patch
M Source/core/editing/ApplyStyleCommand.h View 1 5 chunks +5 lines, -4 lines 0 comments Download
M Source/core/editing/ApplyStyleCommand.cpp View 1 21 chunks +56 lines, -57 lines 0 comments Download
M Source/core/editing/WrapContentsInDummySpanCommand.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/editing/WrapContentsInDummySpanCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Inactive
6 years, 5 months ago (2014-07-25 03:50:54 UTC) #1
Inactive
6 years, 4 months ago (2014-07-25 20:25:28 UTC) #2
leviw_travelin_and_unemployed
lgtm! Keep 'em comin'!
6 years, 4 months ago (2014-07-25 20:35:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/418223004/20001
6 years, 4 months ago (2014-07-25 20:36:18 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-07-25 20:39:37 UTC) #5
Message was sent while issue was closed.
Change committed as 178955

Powered by Google App Engine
This is Rietveld 408576698