 Chromium Code Reviews
 Chromium Code Reviews Issue 418193003:
  Using PROFILE_ANY for vp8 and vp9  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@master
    
  
    Issue 418193003:
  Using PROFILE_ANY for vp8 and vp9  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@master| OLD | NEW | 
|---|---|
| 1 /* Copyright (c) 2014 The Chromium Authors. All rights reserved. | 1 /* Copyright (c) 2014 The Chromium Authors. All rights reserved. | 
| 2 * Use of this source code is governed by a BSD-style license that can be | 2 * Use of this source code is governed by a BSD-style license that can be | 
| 3 * found in the LICENSE file. | 3 * found in the LICENSE file. | 
| 4 */ | 4 */ | 
| 5 | 5 | 
| 6 /** | 6 /** | 
| 7 * Video profiles. | 7 * Video profiles. | 
| 8 */ | 8 */ | 
| 9 enum PP_VideoProfile { | 9 enum PP_VideoProfile { | 
| 10 PP_VIDEOPROFILE_H264BASELINE = 0, | 10 PP_VIDEOPROFILE_H264BASELINE = 0, | 
| 11 PP_VIDEOPROFILE_H264MAIN = 1, | 11 PP_VIDEOPROFILE_H264MAIN = 1, | 
| 12 PP_VIDEOPROFILE_H264EXTENDED = 2, | 12 PP_VIDEOPROFILE_H264EXTENDED = 2, | 
| 13 PP_VIDEOPROFILE_H264HIGH = 3, | 13 PP_VIDEOPROFILE_H264HIGH = 3, | 
| 14 PP_VIDEOPROFILE_H264HIGH10PROFILE = 4, | 14 PP_VIDEOPROFILE_H264HIGH10PROFILE = 4, | 
| 15 PP_VIDEOPROFILE_H264HIGH422PROFILE = 5, | 15 PP_VIDEOPROFILE_H264HIGH422PROFILE = 5, | 
| 16 PP_VIDEOPROFILE_H264HIGH444PREDICTIVEPROFILE = 6, | 16 PP_VIDEOPROFILE_H264HIGH444PREDICTIVEPROFILE = 6, | 
| 17 PP_VIDEOPROFILE_H264SCALABLEBASELINE = 7, | 17 PP_VIDEOPROFILE_H264SCALABLEBASELINE = 7, | 
| 18 PP_VIDEOPROFILE_H264SCALABLEHIGH = 8, | 18 PP_VIDEOPROFILE_H264SCALABLEHIGH = 8, | 
| 19 PP_VIDEOPROFILE_H264STEREOHIGH = 9, | 19 PP_VIDEOPROFILE_H264STEREOHIGH = 9, | 
| 20 PP_VIDEOPROFILE_H264MULTIVIEWHIGH = 10, | 20 PP_VIDEOPROFILE_H264MULTIVIEWHIGH = 10, | 
| 21 PP_VIDEOPROFILE_VP8MAIN = 11, | 21 PP_VIDEOPROFILE_VP8PROFILE_UNSPECIFIED = 11, | 
| 
teravest
2014/07/31 15:35:28
Since these are only used by a dev channel API (PP
 
dmichael (off chromium)
2014/07/31 17:31:49
Totally fine here. Wouldn't even break backwards-c
 
bbudge
2014/07/31 18:11:15
Naming suggestion - this is a little redundant. Ho
 | |
| 22 PP_VIDEOPROFILE_VP9MAIN = 12, | 22 PP_VIDEOPROFILE_VP9PROFILE_UNSPECIFIED = 12, | 
| 23 PP_VIDEOPROFILE_MAX = PP_VIDEOPROFILE_VP9MAIN | 23 PP_VIDEOPROFILE_MAX = PP_VIDEOPROFILE_VP9PROFILE_UNSPECIFIED | 
| 24 }; | 24 }; | 
| 25 | 25 | 
| 26 /** | 26 /** | 
| 27 * Struct describing a decoded video picture. The decoded picture data is stored | 27 * Struct describing a decoded video picture. The decoded picture data is stored | 
| 28 * in the GL texture corresponding to |texture_id|. The plugin can determine | 28 * in the GL texture corresponding to |texture_id|. The plugin can determine | 
| 29 * which Decode call generated the picture using |decode_id|. | 29 * which Decode call generated the picture using |decode_id|. | 
| 30 */ | 30 */ | 
| 31 struct PP_VideoPicture { | 31 struct PP_VideoPicture { | 
| 32 /** | 32 /** | 
| 33 * |decode_id| parameter of the Decode call which generated this picture. | 33 * |decode_id| parameter of the Decode call which generated this picture. | 
| (...skipping 15 matching lines...) Expand all Loading... | |
| 49 * | 49 * | 
| 50 * The pixel format of the texture is GL_RGBA. | 50 * The pixel format of the texture is GL_RGBA. | 
| 51 */ | 51 */ | 
| 52 uint32_t texture_target; | 52 uint32_t texture_target; | 
| 53 | 53 | 
| 54 /** | 54 /** | 
| 55 * Dimensions of the texture holding the decoded picture. | 55 * Dimensions of the texture holding the decoded picture. | 
| 56 */ | 56 */ | 
| 57 PP_Size texture_size; | 57 PP_Size texture_size; | 
| 58 }; | 58 }; | 
| OLD | NEW |