Using PROFILE_ANY for vp8 and vp9

content/common/gpu/media/android_video_decode_accelerator.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/common/gpu/media/android_video_decode_accelerator.h"
 
 #include "base/bind.h"
 #include "base/logging.h"
 #include "base/message_loop/message_loop.h"
 #include "base/metrics/histogram.h"
@@ skipping 71 matching lines @@
   DCHECK(thread_checker_.CalledOnValidThread());
 }
 
 bool AndroidVideoDecodeAccelerator::Initialize(media::VideoCodecProfile profile,
                                                Client* client) {
   DCHECK(!media_codec_);
   DCHECK(thread_checker_.CalledOnValidThread());
 
   client_ = client;
 
-  if (profile == media::VP8PROFILE_MAIN) {
+  if (profile == media::VP8PROFILE_UNSPECIFIED) {

[xhwang, 2014/07/31 17:12:44]

I think here you mean for "vp8", "profile" is "unspecified" in the spec. But
when I look at this, "unspecified" means that it should be specified but not
specified, which isn't the case here. So "unspecified" here is ambiguous.

I think I still like "NOT_NEEDED" better. Pawel, WDYT?

Another option is to use "NOT_APPLICABLE", as in N/A:
http://en.wikipedia.org/wiki/N/a

Based on wikipedia, the meaning is exact what Pawel mentioned in his comment.

Also, we only need one "NOT_NEEDED", which can be shared by all codecs that
don't need a profile (e.g. vp8/vp9). So how about just having:
media::PROFILE_NOT_NEEDED, or
media::PROFILE_NOT_APPLICABLE

[amogh.bihani, 2014/08/01 05:16:24]

Na has a wiki page! :o
Won't creating single NOT_APPLICABLE profile for vp8/9 will make us lose the
distinction that we have between these two codecs, which might be used perhaps
later.

     codec_ = media::kCodecVP8;
   } else {
     // TODO(dwkang): enable H264 once b/8125974 is fixed.
     LOG(ERROR) << "Unsupported profile: " << profile;
     return false;
   }
 
   // Only consider using MediaCodec if it's likely backed by hardware.
   if (media::VideoCodecBridge::IsKnownUnaccelerated(
           codec_, media::MEDIA_CODEC_DECODER)) {
@@ skipping 436 matching lines @@
 void AndroidVideoDecodeAccelerator::NotifyResetDone() {
   client_->NotifyResetDone();
 }
 
 void AndroidVideoDecodeAccelerator::NotifyError(
     media::VideoDecodeAccelerator::Error error) {
   client_->NotifyError(error);
 }
 
 }  // namespace content