Issue 418173012: Revert of Memory improvements to render_pdfs; better DM pool size defaults

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 418173012: Revert of Memory improvements to render_pdfs; better DM pool size defaults (Closed)

Created:
6 years, 4 months ago by hal.canary

Modified:
6 years, 4 months ago

Reviewers:
djsollen, mtklein

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

Revert of Memory improvements to render_pdfs; better DM pool size defaults (https://codereview.chromium.org/433063002/) Reason for revert: breaking android tests Original issue's description: > Memory improvements to render_pdfs; better DM pool size defaults > > Make SK_DEFAULT_GLOBAL_DISCARDABLE_MEMORY_POOL_SIZE equal to > skia_resource_cache_mb_limit, if that value is >0 (true for some > low-memory Android devices). > > render_pdfs test program uses lazy decoding (and the discardable > memory pool). > > BUG=skia:2743 > > Committed: https://skia.googlesource.com/skia/+/66058b614d9c8cb63c24b1c779dd1a9a80752217 TBR=djsollen@google.com,mtklein@google.com NOTREECHECKS=true NOTRY=true BUG=skia:2743 Committed: https://skia.googlesource.com/skia/+/f91b47ff9ea6bd0246dc7c5a3f58d85860661ace

Created: 6 years, 4 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+2 lines, -18 lines)			Patch
M	gyp/common_conditions.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	gyp/tools.gyp	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	src/lazy/SkDiscardableMemoryPool.h	View	1 chunk	+1 line, -8 lines	0 comments	Download
M	tools/render_pdfs_main.cpp	View	2 chunks	+1 line, -4 lines	0 comments	Download

Total messages: 3 (0 generated)

hal.canary

Created Revert of Memory improvements to render_pdfs; better DM pool size defaults

6 years, 4 months ago (2014-08-01 18:53:43 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/halcanary@google.com/418173012/1

6 years, 4 months ago (2014-08-01 18:54:44 UTC) #2

commit-bot: I haz the power

6 years, 4 months ago (2014-08-01 18:54:53 UTC) #3

Message was sent while issue was closed.

Change committed as f91b47ff9ea6bd0246dc7c5a3f58d85860661ace