Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2261)

Unified Diff: chrome/common/extensions/docs/examples/extensions/irc/servlet/index.html

Issue 418173006: extensions: Migrate other uses of webkitNotifications to Web Notifications API. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: review Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/docs/examples/extensions/irc/servlet/index.html
diff --git a/chrome/common/extensions/docs/examples/extensions/irc/servlet/index.html b/chrome/common/extensions/docs/examples/extensions/irc/servlet/index.html
index 17fb215baaa11da3be9f64f646a5a35fae86f23b..8b817da7f00442773782d1b0e90b8c4d6c29b786 100644
--- a/chrome/common/extensions/docs/examples/extensions/irc/servlet/index.html
+++ b/chrome/common/extensions/docs/examples/extensions/irc/servlet/index.html
@@ -327,28 +327,24 @@ function checkForNickReference(server, channel, nick, message) {
}
// Notifications will be enabled by the app install. Otherwise, don't notity.
- if (window.webkitNotifications.checkPermission() != 0) {
+ if (Notification.permission != "granted") {
return;
}
-
+
// Remove a previous notification from the same channel. Show the newer one.
if (notifications[server.name + channel]) {
- notifications[server.name + channel].cancel();
+ notifications[server.name + channel].close();
}
- var title = "On " + server.name + channel;
- var icon = "http://www.google.com/favicon.ico";
- var text = nick + ": " + message;
- var url = location.protocol + "//" + location.host + "/notification.html";
- url += "?title=" + encodeURIComponent(title) +
- "&content=" + encodeURIComponent(text);
+ var n = new Notification("On " + server.name + channel, {
+ icon: "https://www.google.com/favicon.ico",
+ body: nick + ": " + message,
+ });
- var n = window.webkitNotifications.createHTMLNotification(url);
- n.ondisplay = function() {};
+ n.onshow = function() {};
n.onclose = function() {
delete notifications[server.name + channel];
};
- n.show();
notifications[server.name + channel] = n;
}

Powered by Google App Engine
This is Rietveld 408576698