extensions: Migrate other uses of webkitNotifications to Web Notifications API.

chrome/common/extensions/docs/examples/extensions/irc/servlet/index.html

Index: chrome/common/extensions/docs/examples/extensions/irc/servlet/index.html
diff --git a/chrome/common/extensions/docs/examples/extensions/irc/servlet/index.html b/chrome/common/extensions/docs/examples/extensions/irc/servlet/index.html
index 17fb215baaa11da3be9f64f646a5a35fae86f23b..8b0d43ddb6786992003feb4d8cd91e40a4b06121 100644
--- a/chrome/common/extensions/docs/examples/extensions/irc/servlet/index.html
+++ b/chrome/common/extensions/docs/examples/extensions/irc/servlet/index.html
@@ -327,28 +327,24 @@ function checkForNickReference(server, channel, nick, message) {
   }
 
   // Notifications will be enabled by the app install. Otherwise, don't notity.
-  if (window.webkitNotifications.checkPermission() != 0) {
+  if (Notification.permission == "denied") {

[Peter Beverloo, 2014/08/01 08:46:06]

It's possible for |permission| to be "default" here as well. It'd be better if
you'd check for:

if (Notification.permission != "granted")
  return;

[tfarina, 2014/08/02 00:54:05]

Done.

     return;
   }
-  
+
   // Remove a previous notification from the same channel. Show the newer one.
   if (notifications[server.name + channel]) {
-    notifications[server.name + channel].cancel();
+    notifications[server.name + channel].close();
   }
 
-  var title = "On " + server.name + channel;
-  var icon = "http://www.google.com/favicon.ico";
-  var text = nick + ": " + message;
-  var url = location.protocol + "//" + location.host + "/notification.html";
-  url += "?title=" + encodeURIComponent(title) +
-         "&content=" + encodeURIComponent(text);
+  var n = new Notification("On " + server.name + changel, {

[Peter Beverloo, 2014/08/01 08:46:06]

s/changel/channel/

[tfarina, 2014/08/02 00:54:05]

Done.

+    icon: "http://www.google.com/favicon.icon",

[Peter Beverloo, 2014/08/01 08:46:06]

That file doesn't actually exist :-). Not your bad, but would you mind updating
this to:

https://www.google.com/favicon.ico

[tfarina, 2014/08/02 00:54:06]

Done.

+    body: nick + ": " + message,
+  });
 
-  var n = window.webkitNotifications.createHTMLNotification(url);
-  n.ondisplay = function() {};
+  n.onshow = function() {};

[not at google - send to devlin, 2014/08/01 16:52:29]

do you need to set this?

[Peter Beverloo, 2014/08/01 16:53:34]

I figured that it's for demonstrative purposes given that the old version also
included |ondisplay|, and that this is an example.

It can safely be removed.

[not at google - send to devlin, 2014/08/01 16:59:51]

Good point. Leaving it in SGTM.

[tfarina, 2014/08/02 00:54:06]

Done.

   n.onclose = function() {
     delete notifications[server.name + channel];
   };
-  n.show();
 
   notifications[server.name + channel] = n;
 }