Source/core/css/resolver/MatchedPropertiesCache.cpp - Issue 418163003: Simplify watched selector handling and remove remnants of user stylesheets

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/resolver/MatchedPropertiesCache.cpp

Issue 418163003: Simplify watched selector handling and remove remnants of user stylesheets (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@cascade

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/core/css/resolver/MatchResult.cpp ('k') | Source/core/css/resolver/StyleBuilderCustom.cpp » ('j') | Source/core/css/resolver/StyleResolver.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/css/resolver/MatchedPropertiesCache.cpp

diff --git a/Source/core/css/resolver/MatchedPropertiesCache.cpp b/Source/core/css/resolver/MatchedPropertiesCache.cpp

index 585d8dfaab029c1014871d0c2407b5abfe438586..75ecb2a37079ab3e2a1e958bcd6cd444ac40fadd 100644

--- a/Source/core/css/resolver/MatchedPropertiesCache.cpp

+++ b/Source/core/css/resolver/MatchedPropertiesCache.cpp

@@ -191,9 +191,6 @@ bool MatchedPropertiesCache::isCacheable(const Element* element, const RenderSty

return false;

if (style->hasCurrentColor())

return false;

- // CSSPropertyInternalCallback sets the rule's selector name into the RenderStyle, and that's not recalculated if the RenderStyle is loaded from the cache, so don't cache it.

- if (!style->callbackSelectors().isEmpty())

- return false;

// The cache assumes static knowledge about which properties are inherited.

if (parentStyle->hasExplicitlyInheritedProperties())

return false;

« no previous file with comments | « Source/core/css/resolver/MatchResult.cpp ('k') | Source/core/css/resolver/StyleBuilderCustom.cpp » ('j') | Source/core/css/resolver/StyleResolver.h » ('J')