Simplify watched selector handling and remove remnants of user stylesheets

Source/core/dom/CSSSelectorWatch.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 125 matching lines @@
             return false;
     }
     return true;
 }
 
 void CSSSelectorWatch::watchCSSSelectors(const Vector<String>& selectors)
 {
     m_watchedCallbackSelectors.clear();
     BisonCSSParser parser(CSSParserContext(UASheetMode, 0));
 
-    const CSSProperty callbackProperty(CSSPropertyInternalCallback, CSSPrimitiveValue::createIdentifier(CSSValueInternalPresence));
+    // We need a property declaration here otherwise the StylePropertySet will
+    // get ignored. The exact property used doesn't matter as it isn't applied.
+    const CSSProperty callbackProperty(CSSPropertyBackgroundColor, CSSPrimitiveValue::createIdentifier(CSSValueRed));

[esprehn, 2014/08/15 14:45:55]

This hack feels pretty gross, we can't leave that old property?

[Timothy Loh, 2014/08/15 15:29:14]

Turns out there's a flag on MatchRequest to make us not ignore empty
StylePropertySets, so we don't need a property here any more.

     const RefPtrWillBeRawPtr<StylePropertySet> callbackPropertySet = ImmutableStylePropertySet::create(&callbackProperty, 1, UASheetMode);
 
     CSSSelectorList selectorList;
     for (unsigned i = 0; i < selectors.size(); ++i) {
         parser.parseSelector(selectors[i], selectorList);
         if (!selectorList.isValid())
             continue;
 
         // Only accept Compound Selectors, since they're cheaper to match.
         if (!allCompound(selectorList))
             continue;
 
         RefPtrWillBeRawPtr<StyleRule> rule = StyleRule::create();
         rule->wrapperAdoptSelectorList(selectorList);
         rule->setProperties(callbackPropertySet);
         m_watchedCallbackSelectors.append(rule.release());
     }
     document().changedSelectorWatch();
 }
 
 void CSSSelectorWatch::trace(Visitor* visitor)
 {
     visitor->trace(m_watchedCallbackSelectors);
     visitor->trace(m_document);
     DocumentSupplement::trace(visitor);
 }
 
 } // namespace blink