Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(493)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 418143007: FYI Implementing 'super' keyword (Closed)

Created:
6 years, 5 months ago by Dmitry Lomov (no reviews)
Modified:
6 years, 2 months ago
Reviewers:
adamk
CC:
adamk, arv (Not doing code reviews), marja, rossberg, v8-dev
Project:
v8
Visibility:
Public.

Description

Implementing 'super' keyword

Patch Set 1 #

Patch Set 2 : Parser tests #

Patch Set 3 : ToMethod and home objects #

Patch Set 4 : Rebase + test #

Patch Set 5 : Loads, stores and calls #

Patch Set 6 : one more test #

Total comments: 4

Patch Set 7 : Use private own symbol for [[HomeObject]] #

Unified diffs Side-by-side diffs Delta from patch set Stats (+696 lines, -484 lines) Patch
M include/v8.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M src/ast.h View 1 2 3 4 5 6 4 chunks +49 lines, -21 lines 0 comments Download
M src/ast.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 1 2 3 4 5 6 1 chunk +5 lines, -0 lines 0 comments Download
M src/full-codegen.h View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M src/full-codegen.cc View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
M src/heap/heap.h View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M src/heap/heap.cc View 1 2 3 4 5 6 3 chunks +24 lines, -1 line 0 comments Download
M src/hydrogen.cc View 1 2 3 4 5 6 1 chunk +5 lines, -0 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 2 3 4 5 6 4 chunks +46 lines, -4 lines 0 comments Download
M src/messages.js View 1 2 3 4 5 6 1 chunk +2 lines, -1 line 0 comments Download
M src/objects.h View 1 2 3 4 5 6 1 chunk +314 lines, -325 lines 0 comments Download
M src/parser.h View 1 2 3 4 5 6 1 chunk +3 lines, -0 lines 0 comments Download
M src/parser.cc View 1 2 3 4 5 6 1 chunk +6 lines, -0 lines 0 comments Download
M src/preparser.h View 1 2 3 4 5 6 6 chunks +32 lines, -3 lines 0 comments Download
M src/prettyprinter.cc View 1 2 3 2 chunks +10 lines, -0 lines 0 comments Download
M src/runtime.h View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime.cc View 1 2 3 4 5 6 1 chunk +13 lines, -0 lines 0 comments Download
M src/scanner.cc View 1 2 3 1 chunk +63 lines, -63 lines 0 comments Download
M src/token.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M src/typing.cc View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M test/cctest/test-parsing.cc View 1 2 3 4 5 6 1 chunk +44 lines, -0 lines 0 comments Download
A + test/mjsunit/harmony/super.js View 1 2 3 4 2 chunks +37 lines, -35 lines 0 comments Download
A + test/mjsunit/harmony/toMethod.js View 1 2 3 4 5 6 1 chunk +27 lines, -27 lines 0 comments Download
A + test/mjsunit/runtime-gen/tomethod.js View 1 2 3 4 5 6 1 chunk +2 lines, -1 line 0 comments Download
M tools/generate-runtime-tests.py View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Dmitry Lomov (no reviews)
NOT FOR LANDIND. This patch is a prototype implementation of 'super' keyword and 'Function.prototype.toMethod'. It ...
6 years, 4 months ago (2014-08-06 16:01:01 UTC) #1
adamk
https://codereview.chromium.org/418143007/diff/120001/src/ia32/full-codegen-ia32.cc File src/ia32/full-codegen-ia32.cc (right): https://codereview.chromium.org/418143007/diff/120001/src/ia32/full-codegen-ia32.cc#newcode1287 src/ia32/full-codegen-ia32.cc:1287: __ mov(r, FieldOperand(r, JSFunction::kHomeObjectOffset)); You mentioned that you're thinking ...
6 years, 4 months ago (2014-08-07 20:38:04 UTC) #2
Dmitry Lomov (no reviews)
On 2014/08/07 20:38:04, adamk wrote: > https://codereview.chromium.org/418143007/diff/120001/src/ia32/full-codegen-ia32.cc > File src/ia32/full-codegen-ia32.cc (right): > > https://codereview.chromium.org/418143007/diff/120001/src/ia32/full-codegen-ia32.cc#newcode1287 > ...
6 years, 4 months ago (2014-08-10 17:21:15 UTC) #3
marja
Some drive-by nits: https://codereview.chromium.org/418143007/diff/120001/test/cctest/test-parsing.cc File test/cctest/test-parsing.cc (right): https://codereview.chromium.org/418143007/diff/120001/test/cctest/test-parsing.cc#newcode3353 test/cctest/test-parsing.cc:3353: // Tests that parser and preparser ...
6 years, 4 months ago (2014-08-11 10:38:16 UTC) #4
Dmitry Lomov (no reviews)
6 years, 4 months ago (2014-08-13 13:29:01 UTC) #5 
Patch Set 7 uses private own symbols to implement [[HomeObject]].
It is the finest available.

Powered by Google App Engine
This is Rietveld 408576698