content/renderer/media/webmediaplayer_impl.h - Issue 418143005: media: Introduce Renderer interface and RendererImpl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/webmediaplayer_impl.h

Issue 418143005: media: Introduce Renderer interface and RendererImpl. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: minor cleanup Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/media/webmediaplayer_impl.h

diff --git a/content/renderer/media/webmediaplayer_impl.h b/content/renderer/media/webmediaplayer_impl.h

index 522519bf24b1ac777abdfd768339b081a206004a..19cd93ac00a7b46e743f99b0eaceae08d2792d05 100644

--- a/content/renderer/media/webmediaplayer_impl.h

+++ b/content/renderer/media/webmediaplayer_impl.h

@@ -202,6 +202,9 @@ class WebMediaPlayerImpl

// Called when the data source is downloading or paused.

void NotifyDownloading(bool is_downloading);

+ // Creates a media::Renderer that will be used by the Pipeline.

scherkus (not reviewing) 2014/08/22 20:50:01 nit: s/Pipeline/|pipeline_|/?

xhwang 2014/08/22 22:48:22 Done.

+ scoped_ptr<media::Renderer> CreateRenderer();

// Finishes starting the pipeline due to a call to load().

void StartPipeline();