Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Side by Side Diff: chrome/browser/ui/website_settings/website_settings.cc

Issue 418133012: Add button to page info to revoke user certificate decisions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/website_settings/website_settings.h" 5 #include "chrome/browser/ui/website_settings/website_settings.h"
6 6
7 #include <string> 7 #include <string>
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/bind.h" 10 #include "base/bind.h"
(...skipping 12 matching lines...) Expand all
23 #include "chrome/browser/browsing_data/browsing_data_local_storage_helper.h" 23 #include "chrome/browser/browsing_data/browsing_data_local_storage_helper.h"
24 #include "chrome/browser/content_settings/content_settings_utils.h" 24 #include "chrome/browser/content_settings/content_settings_utils.h"
25 #include "chrome/browser/content_settings/host_content_settings_map.h" 25 #include "chrome/browser/content_settings/host_content_settings_map.h"
26 #include "chrome/browser/content_settings/local_shared_objects_container.h" 26 #include "chrome/browser/content_settings/local_shared_objects_container.h"
27 #include "chrome/browser/history/history_service_factory.h" 27 #include "chrome/browser/history/history_service_factory.h"
28 #include "chrome/browser/profiles/profile.h" 28 #include "chrome/browser/profiles/profile.h"
29 #include "chrome/browser/ssl/ssl_error_info.h" 29 #include "chrome/browser/ssl/ssl_error_info.h"
30 #include "chrome/browser/ui/website_settings/website_settings_infobar_delegate.h " 30 #include "chrome/browser/ui/website_settings/website_settings_infobar_delegate.h "
31 #include "chrome/browser/ui/website_settings/website_settings_ui.h" 31 #include "chrome/browser/ui/website_settings/website_settings_ui.h"
32 #include "chrome/common/content_settings_pattern.h" 32 #include "chrome/common/content_settings_pattern.h"
33 #include "content/browser/ssl/ssl_host_state.h"
33 #include "content/public/browser/browser_thread.h" 34 #include "content/public/browser/browser_thread.h"
34 #include "content/public/browser/cert_store.h" 35 #include "content/public/browser/cert_store.h"
35 #include "content/public/browser/user_metrics.h" 36 #include "content/public/browser/user_metrics.h"
36 #include "content/public/common/content_switches.h" 37 #include "content/public/common/content_switches.h"
37 #include "content/public/common/ssl_status.h" 38 #include "content/public/common/ssl_status.h"
38 #include "content/public/common/url_constants.h" 39 #include "content/public/common/url_constants.h"
39 #include "grit/chromium_strings.h" 40 #include "grit/chromium_strings.h"
40 #include "grit/generated_resources.h" 41 #include "grit/generated_resources.h"
41 #include "net/base/registry_controlled_domains/registry_controlled_domain.h" 42 #include "net/base/registry_controlled_domains/registry_controlled_domain.h"
42 #include "net/cert/cert_status_flags.h" 43 #include "net/cert/cert_status_flags.h"
(...skipping 483 matching lines...) Expand 10 before | Expand all | Expand 10 after
526 site_connection_details_ += l10n_util::GetStringUTF16( 527 site_connection_details_ += l10n_util::GetStringUTF16(
527 IDS_PAGE_INFO_SECURITY_TAB_FALLBACK_MESSAGE); 528 IDS_PAGE_INFO_SECURITY_TAB_FALLBACK_MESSAGE);
528 } 529 }
529 if (no_renegotiation) { 530 if (no_renegotiation) {
530 site_connection_details_ += ASCIIToUTF16("\n\n"); 531 site_connection_details_ += ASCIIToUTF16("\n\n");
531 site_connection_details_ += l10n_util::GetStringUTF16( 532 site_connection_details_ += l10n_util::GetStringUTF16(
532 IDS_PAGE_INFO_SECURITY_TAB_RENEGOTIATION_MESSAGE); 533 IDS_PAGE_INFO_SECURITY_TAB_RENEGOTIATION_MESSAGE);
533 } 534 }
534 } 535 }
535 536
537 // Check if a user decision has been made to allow or deny some certificates
Peter Kasting 2014/07/26 02:40:39 Nit: What does the "some" inserted in this sentenc
jww 2014/07/27 17:29:26 Yup, the "some" was extraneous. Fixed.
538 // with errors on this site.
539 content::SSLHostState* host_state = content::SSLHostState::GetFor(profile);
540 certificate_decision_made_ = host_state->HasAllowedOrDeniedCert(url.host());
541
536 // By default select the permissions tab that displays all the site 542 // By default select the permissions tab that displays all the site
537 // permissions. In case of a connection error or an issue with the 543 // permissions. In case of a connection error or an issue with the
538 // certificate presented by the website, select the connection tab to draw 544 // certificate presented by the website, select the connection tab to draw
539 // the user's attention to the issue. If the site does not provide a 545 // the user's attention to the issue. If the site does not provide a
540 // certificate because it was loaded over an unencrypted connection, don't 546 // certificate because it was loaded over an unencrypted connection, don't
541 // select the connection tab. 547 // select the connection tab.
542 WebsiteSettingsUI::TabId tab_id = WebsiteSettingsUI::TAB_ID_PERMISSIONS; 548 WebsiteSettingsUI::TabId tab_id = WebsiteSettingsUI::TAB_ID_PERMISSIONS;
543 if (site_connection_status_ == SITE_CONNECTION_STATUS_ENCRYPTED_ERROR || 549 if (site_connection_status_ == SITE_CONNECTION_STATUS_ENCRYPTED_ERROR ||
544 site_connection_status_ == SITE_CONNECTION_STATUS_MIXED_CONTENT || 550 site_connection_status_ == SITE_CONNECTION_STATUS_MIXED_CONTENT ||
545 site_identity_status_ == SITE_IDENTITY_STATUS_ERROR || 551 site_identity_status_ == SITE_IDENTITY_STATUS_ERROR ||
(...skipping 113 matching lines...) Expand 10 before | Expand all | Expand 10 after
659 info.connection_status = site_connection_status_; 665 info.connection_status = site_connection_status_;
660 info.connection_status_description = 666 info.connection_status_description =
661 UTF16ToUTF8(site_connection_details_); 667 UTF16ToUTF8(site_connection_details_);
662 info.identity_status = site_identity_status_; 668 info.identity_status = site_identity_status_;
663 info.identity_status_description = 669 info.identity_status_description =
664 UTF16ToUTF8(site_identity_details_); 670 UTF16ToUTF8(site_identity_details_);
665 info.cert_id = cert_id_; 671 info.cert_id = cert_id_;
666 info.signed_certificate_timestamp_ids.assign( 672 info.signed_certificate_timestamp_ids.assign(
667 signed_certificate_timestamp_ids_.begin(), 673 signed_certificate_timestamp_ids_.begin(),
668 signed_certificate_timestamp_ids_.end()); 674 signed_certificate_timestamp_ids_.end());
675 info.certificate_decision_made = certificate_decision_made_;
669 ui_->SetIdentityInfo(info); 676 ui_->SetIdentityInfo(info);
670 } 677 }
671 678
672 void WebsiteSettings::PresentHistoryInfo(base::Time first_visit) { 679 void WebsiteSettings::PresentHistoryInfo(base::Time first_visit) {
673 if (first_visit == base::Time()) { 680 if (first_visit == base::Time()) {
674 ui_->SetFirstVisit(base::string16()); 681 ui_->SetFirstVisit(base::string16());
675 return; 682 return;
676 } 683 }
677 684
678 bool visited_before_today = false; 685 bool visited_before_today = false;
679 base::Time today = base::Time::Now().LocalMidnight(); 686 base::Time today = base::Time::Now().LocalMidnight();
680 base::Time first_visit_midnight = first_visit.LocalMidnight(); 687 base::Time first_visit_midnight = first_visit.LocalMidnight();
681 visited_before_today = (first_visit_midnight < today); 688 visited_before_today = (first_visit_midnight < today);
682 689
683 base::string16 first_visit_text; 690 base::string16 first_visit_text;
684 if (visited_before_today) { 691 if (visited_before_today) {
685 first_visit_text = l10n_util::GetStringFUTF16( 692 first_visit_text = l10n_util::GetStringFUTF16(
686 IDS_PAGE_INFO_SECURITY_TAB_VISITED_BEFORE_TODAY, 693 IDS_PAGE_INFO_SECURITY_TAB_VISITED_BEFORE_TODAY,
687 base::TimeFormatShortDate(first_visit)); 694 base::TimeFormatShortDate(first_visit));
688 } else { 695 } else {
689 first_visit_text = l10n_util::GetStringUTF16( 696 first_visit_text = l10n_util::GetStringUTF16(
690 IDS_PAGE_INFO_SECURITY_TAB_FIRST_VISITED_TODAY); 697 IDS_PAGE_INFO_SECURITY_TAB_FIRST_VISITED_TODAY);
691 } 698 }
692 ui_->SetFirstVisit(first_visit_text); 699 ui_->SetFirstVisit(first_visit_text);
693 } 700 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698