Add button to page info to revoke user certificate decisions.

chrome/browser/ui/views/website_settings/website_settings_popup_view.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_VIEWS_WEBSITE_SETTINGS_WEBSITE_SETTINGS_POPUP_VIEW_H_
 #define CHROME_BROWSER_UI_VIEWS_WEBSITE_SETTINGS_WEBSITE_SETTINGS_POPUP_VIEW_H_
 
 #include "base/basictypes.h"
 #include "base/compiler_specific.h"
 #include "base/memory/scoped_ptr.h"
@@ skipping 100 matching lines @@
   // are cleared and destroyed first. Then the |icon|, |headline|, |text| and
   // |link| are layout out properly. If the |headline| is an empty string then
   // no headline will be displayed. The ownership of the passed |link| is
   // transfered to the ResetConnectionSection method and the |link| is added to
   // the views hierarchy. If the |link| is NULL then no link is be displayed.
   void ResetConnectionSection(views::View* section_container,
                               const gfx::Image& icon,
                               const base::string16& headline,
                               const base::string16& text,
                               views::Link* link,
-                              views::Link* secondary_link);
+                              views::Link* secondary_link,
+                              views::Link* reset_decisions_button);
   // Handles LinkClicked asynchronously.
   void HandleLinkClickedAsync(views::Link* source);
 
   // The web contents of the current tab. The popup can't live longer than a
   // tab.
   content::WebContents* web_contents_;
 
   // The Browser is used to load the help center page.
   Browser* browser_;
 
@@ skipping 20 matching lines @@
   // the site's identity.
   views::View* identity_info_content_;
   // The link to open the certificate viewer for displaying the certificate
   // provided by the website. If the site does not provide a certificate then
   // |certificate_dialog_link_| is NULL.
   views::Link* certificate_dialog_link_;
   // The link to open the signed certificate timestamps viewer for displaying
   // Certificate Transparency info. If no such SCTs accompany the certificate
   // then |signed_certificate_timestamps_link_| is NULL.
   views::Link* signed_certificate_timestamps_link_;
+  // The button to reset the Allow/Deny certificate errors decision for the
+  // current host.
+  views::Link* reset_decisions_button_;

[Peter Kasting, 2014/07/26 02:40:39]

Your comment and variable name call this a button, but the type is Link.  These
need to be consistent.  If clicking this takes some action, as opposed to going
to another page or something, this should actually be a button, not a link.

[jww, 2014/07/27 17:29:26]

After going over the designs with ainsle@, this a link-like text even though it
is resetting the security decisions (and only closing the page info). This is
also consistent with the new SSL error interstitial, where, for example, the
proceed decision itself is a link, not a button. Would it still be better to
change the comment and variable this to 'link'?

[Peter Kasting, 2014/07/28 11:07:44]

An interstitial is web content, and a clickable target that causes that
interstitial to be navigated away makes sense to be a link.  The page info
dropdown is native UI, and buttons that take actions to affect browser state
should be buttons, not links.  We used to be inconsistent about this, e.g. by
having a "Remove" link (instead of button) on the star bubble, but we've fixed
all the cases I'm aware of, so I'm going to stand firm on this one.  If
necessary, put me in touch with Alex directly.

 
   // The id of the certificate provided by the site. If the site does not
   // provide a certificate then |cert_id_| is 0.
   int cert_id_;
   // The IDs and validation status of Signed Certificate TImestamps provided
   // by the site. Empty if no SCTs accompany the certificate.
   content::SignedCertificateTimestampIDStatusList
       signed_certificate_timestamp_ids_;
 
   // The link to open the help center page that contains more information about
   // the connection status icons.
   views::Link* help_center_link_;
 
   views::View* connection_info_content_;
   views::View* page_info_content_;
 
   base::WeakPtrFactory<WebsiteSettingsPopupView> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(WebsiteSettingsPopupView);
 };
 
 #endif  // CHROME_BROWSER_UI_VIEWS_WEBSITE_SETTINGS_WEBSITE_SETTINGS_POPUP_VIEW_H_