Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(959)

Unified Diff: Source/core/page/TouchAdjustment.cpp

Issue 418133010: Fix touch adjustment to never return pseudo elements (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: kevers CR feedback Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/touchadjustment/pseudo-element-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/page/TouchAdjustment.cpp
diff --git a/Source/core/page/TouchAdjustment.cpp b/Source/core/page/TouchAdjustment.cpp
index 0608569bd70218364152198f5c6fdd57f4c4ef2f..1e657a8d9ae6495ffa7fee556b58b37205077c3d 100644
--- a/Source/core/page/TouchAdjustment.cpp
+++ b/Source/core/page/TouchAdjustment.cpp
@@ -473,6 +473,11 @@ bool findNodeWithLowestDistanceMetric(Node*& targetNode, IntPoint& targetPoint,
}
}
}
+
+ // As for HitTestResult.innerNode, we skip over pseudo elements.
+ if (targetNode && targetNode->isPseudoElement())
+ targetNode = targetNode->parentOrShadowHostNode();
+
if (targetNode) {
targetArea = targetNode->document().view()->contentsToWindow(targetArea);
}
« no previous file with comments | « LayoutTests/touchadjustment/pseudo-element-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698