Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1273)

Unified Diff: Source/core/page/TouchAdjustment.cpp

Issue 418133010: Fix touch adjustment to never return pseudo elements (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/page/TouchAdjustment.cpp
diff --git a/Source/core/page/TouchAdjustment.cpp b/Source/core/page/TouchAdjustment.cpp
index 89d396a8a24728abd57ca06c9864f777bcdc1655..cd5d4d30b9ba43bef2a07ac18dc949a54778f74c 100644
--- a/Source/core/page/TouchAdjustment.cpp
+++ b/Source/core/page/TouchAdjustment.cpp
@@ -473,6 +473,11 @@ bool findNodeWithLowestDistanceMetric(Node*& targetNode, IntPoint& targetPoint,
}
}
}
+
+ // As for HitTestResult.innerNode, we skip over pseudo elements.
+ if (targetNode && targetNode->isPseudoElement())
+ targetNode = targetNode->parentOrShadowHostNode();
+
if (targetNode) {
targetArea = targetNode->document().view()->contentsToWindow(targetArea);
}

Powered by Google App Engine
This is Rietveld 408576698