LayoutTests/touchadjustment/pseudo-element-expected.txt - Issue 418133010: Fix touch adjustment to never return pseudo elements

Side by Side Diff: LayoutTests/touchadjustment/pseudo-element-expected.txt

Issue 418133010: Fix touch adjustment to never return pseudo elements (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« LayoutTests/touchadjustment/pseudo-element.html ('K') | « LayoutTests/touchadjustment/pseudo-element.html ('k') | Source/core/page/TouchAdjustment.cpp » ('j') | no next file with comments »

OLD	NEW
1 Test touch adjustment on a large div. The adjusted touch point should lie inside the target element and within the touch area.	1 Test touch adjustment over pseudo elements. Pseudo elements should be candidates for adjustment, but should not themselves be returned as valid target nodes.

2	2

3 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE ".	3 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE ".

4	4

5	5

6	6 Test touch area contained within the pseudo element.

7 Overlapping touch above the target should snap to the top of the target element.

8 PASS adjustedNode.id is element.id	7 PASS adjustedNode.id is element.id
Rick Byers 2014/07/25 19:59:13 Note that the failure mode of this test before my Note that the failure mode of this test before my fix is to FAIL here (and at each ID check in the cases below) because adjustedNode.id is empty (since it's the pseudo element node). The co-ordinates were already correct. I'm testing them here to verify I didn't break consideration of pseudo elements in touch adjustment decisions.
9 PASS adjustedPoint.x >= targetBounds.left is true	8 PASS adjustedPoint.x >= targetBounds.left is true

10 PASS adjustedPoint.x <= targetBounds.left + targetBounds.width is true	9 PASS adjustedPoint.x <= targetBounds.left + targetBounds.width is true

11 PASS adjustedPoint.y >= targetBounds.top is true	10 PASS adjustedPoint.y >= targetBounds.top is true

12 PASS adjustedPoint.y <= targetBounds.top + targetBounds.height is true	11 PASS adjustedPoint.y <= targetBounds.top + targetBounds.height is true

13 PASS adjustedPoint.x >= touchBounds.x is true	12 PASS adjustedPoint.x >= touchBounds.x is true

14 PASS adjustedPoint.x <= touchBounds.x + touchBounds.width is true	13 PASS adjustedPoint.x <= touchBounds.x + touchBounds.width is true

15 PASS adjustedPoint.y >= touchBounds.y is true	14 PASS adjustedPoint.y >= touchBounds.y is true

16 PASS adjustedPoint.y <= touchBounds.y + touchBounds.height is true	15 PASS adjustedPoint.y <= touchBounds.y + touchBounds.height is true

17	16

18 Overlapping touch below the target should snap to the bottom of the target eleme nt.	17 Overlapping touch above the target should snap to the top of the pseudo element.

19 PASS adjustedNode.id is element.id	18 PASS adjustedNode.id is element.id

20 PASS adjustedPoint.x >= targetBounds.left is true	19 PASS adjustedPoint.x >= targetBounds.left is true

21 PASS adjustedPoint.x <= targetBounds.left + targetBounds.width is true	20 PASS adjustedPoint.x <= targetBounds.left + targetBounds.width is true

22 PASS adjustedPoint.y >= targetBounds.top is true	21 PASS adjustedPoint.y >= targetBounds.top is true

23 PASS adjustedPoint.y <= targetBounds.top + targetBounds.height is true	22 PASS adjustedPoint.y <= targetBounds.top + targetBounds.height is true

24 PASS adjustedPoint.x >= touchBounds.x is true	23 PASS adjustedPoint.x >= touchBounds.x is true

25 PASS adjustedPoint.x <= touchBounds.x + touchBounds.width is true	24 PASS adjustedPoint.x <= touchBounds.x + touchBounds.width is true

26 PASS adjustedPoint.y >= touchBounds.y is true	25 PASS adjustedPoint.y >= touchBounds.y is true

27 PASS adjustedPoint.y <= touchBounds.y + touchBounds.height is true	26 PASS adjustedPoint.y <= touchBounds.y + touchBounds.height is true

28	27

29 Overlapping touch left of the target should snap to the left side of the target element.	28 Overlapping touch below the target should snap to the bottom of the pseudo eleme nt.

30 PASS adjustedNode.id is element.id	29 PASS adjustedNode.id is element.id

31 PASS adjustedPoint.x >= targetBounds.left is true	30 PASS adjustedPoint.x >= targetBounds.left is true

32 PASS adjustedPoint.x <= targetBounds.left + targetBounds.width is true	31 PASS adjustedPoint.x <= targetBounds.left + targetBounds.width is true

33 PASS adjustedPoint.y >= targetBounds.top is true	32 PASS adjustedPoint.y >= targetBounds.top is true

34 PASS adjustedPoint.y <= targetBounds.top + targetBounds.height is true	33 PASS adjustedPoint.y <= targetBounds.top + targetBounds.height is true

35 PASS adjustedPoint.x >= touchBounds.x is true	34 PASS adjustedPoint.x >= touchBounds.x is true

36 PASS adjustedPoint.x <= touchBounds.x + touchBounds.width is true	35 PASS adjustedPoint.x <= touchBounds.x + touchBounds.width is true

37 PASS adjustedPoint.y >= touchBounds.y is true	36 PASS adjustedPoint.y >= touchBounds.y is true

38 PASS adjustedPoint.y <= touchBounds.y + touchBounds.height is true	37 PASS adjustedPoint.y <= touchBounds.y + touchBounds.height is true

39	38

40 Overlapping touch right of the target should snap to the right side of the targe t element.	39 Overlapping touch left of the target should snap to the left side of the pseudo element.

41 PASS adjustedNode.id is element.id	40 PASS adjustedNode.id is element.id

42 PASS adjustedPoint.x >= targetBounds.left is true	41 PASS adjustedPoint.x >= targetBounds.left is true

43 PASS adjustedPoint.x <= targetBounds.left + targetBounds.width is true	42 PASS adjustedPoint.x <= targetBounds.left + targetBounds.width is true

44 PASS adjustedPoint.y >= targetBounds.top is true	43 PASS adjustedPoint.y >= targetBounds.top is true

45 PASS adjustedPoint.y <= targetBounds.top + targetBounds.height is true	44 PASS adjustedPoint.y <= targetBounds.top + targetBounds.height is true

46 PASS adjustedPoint.x >= touchBounds.x is true	45 PASS adjustedPoint.x >= touchBounds.x is true

47 PASS adjustedPoint.x <= touchBounds.x + touchBounds.width is true	46 PASS adjustedPoint.x <= touchBounds.x + touchBounds.width is true

48 PASS adjustedPoint.y >= touchBounds.y is true	47 PASS adjustedPoint.y >= touchBounds.y is true

49 PASS adjustedPoint.y <= touchBounds.y + touchBounds.height is true	48 PASS adjustedPoint.y <= touchBounds.y + touchBounds.height is true

50	49

51 Test touch area contained within the target element.	50 Overlapping touch right of the target should snap to the right side of the pseud o element.

52 PASS adjustedNode.id is element.id	51 PASS adjustedNode.id is element.id

53 PASS adjustedPoint.x >= targetBounds.left is true	52 PASS adjustedPoint.x >= targetBounds.left is true

54 PASS adjustedPoint.x <= targetBounds.left + targetBounds.width is true	53 PASS adjustedPoint.x <= targetBounds.left + targetBounds.width is true

55 PASS adjustedPoint.y >= targetBounds.top is true	54 PASS adjustedPoint.y >= targetBounds.top is true

56 PASS adjustedPoint.y <= targetBounds.top + targetBounds.height is true	55 PASS adjustedPoint.y <= targetBounds.top + targetBounds.height is true

57 PASS adjustedPoint.x >= touchBounds.x is true	56 PASS adjustedPoint.x >= touchBounds.x is true

58 PASS adjustedPoint.x <= touchBounds.x + touchBounds.width is true	57 PASS adjustedPoint.x <= touchBounds.x + touchBounds.width is true

59 PASS adjustedPoint.y >= touchBounds.y is true	58 PASS adjustedPoint.y >= touchBounds.y is true

60 PASS adjustedPoint.y <= touchBounds.y + touchBounds.height is true	59 PASS adjustedPoint.y <= touchBounds.y + touchBounds.height is true

	60

61 PASS successfullyParsed is true	61 PASS successfullyParsed is true

62	62

63 TEST COMPLETE	63 TEST COMPLETE

64	64

OLD	NEW