Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Issue 418133007: Fix warnings about missing i18n strings in desktop user manager (Closed)

Created:
6 years, 5 months ago by bartfab (slow)
Modified:
6 years, 5 months ago
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Fix warnings about missing i18n strings in desktop user manager Some i18n strings are referenced by the user pod template but never actually shown on desktop. These need to be set to dummy values (e.g. blank) to avoid warnings. This CL fixes warnings for four recently added i18n strings. BUG=397175 TEST=Manual: Warnings no longer seen in log output Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285628

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M chrome/browser/ui/webui/signin/user_manager_screen_handler.cc View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
bartfab (slow)
Hi Monica, please take a look. Pavel, FYI.
6 years, 5 months ago (2014-07-25 12:14:05 UTC) #1
dzhioev (left Google)
On 2014/07/25 12:14:05, bartfab wrote: > Hi Monica, please take a look. > > Pavel, ...
6 years, 5 months ago (2014-07-25 12:17:43 UTC) #2
noms (inactive)
lgtm. Thanks!
6 years, 5 months ago (2014-07-25 15:12:37 UTC) #3
bartfab (slow)
The CQ bit was checked by bartfab@chromium.org
6 years, 5 months ago (2014-07-25 16:03:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bartfab@chromium.org/418133007/1
6 years, 5 months ago (2014-07-25 16:04:48 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_compile_dbg on tryserver.chromium ...
6 years, 5 months ago (2014-07-25 17:52:39 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-25 18:44:48 UTC) #7
Message was sent while issue was closed.
Change committed as 285628

Powered by Google App Engine
This is Rietveld 408576698