Issue 418133006: Replace the argument of nonsfi::MainStart with raw file descriptor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 418133006: Replace the argument of nonsfi::MainStart with raw file descriptor. (Closed)

Created:
6 years, 5 months ago by hidehiko

Modified:
6 years, 5 months ago

Reviewers:
Mark Seaborn

CC:
chromium-reviews, hamaji, teravest, dmichael (off chromium)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Replace the argument of nonsfi::MainStart with raw file descriptor. This is the refactoring to prepare newlib switching. By this CL, we can easily use elf_loader defined in native_client repository, even for making a working demo. TEST=Ran trybots. BUG=358465 CQ_EXTRA_TRYBOTS=tryserver.chromium:linux_rel_precise32 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285801

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -9 lines)			Patch
M	components/nacl/loader/nacl_listener.cc	View	2 chunks	+1 line, -4 lines	0 comments	Download
M	components/nacl/loader/nonsfi/nonsfi_main.h	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	components/nacl/loader/nonsfi/nonsfi_main.cc	View	2 chunks	+5 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

hidehiko

Hi Mark, I'd like to make a small refactoring to prepare making a working demo ...

6 years, 5 months ago (2014-07-25 11:14:11 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hidehiko@chromium.org/418133006/1

6 years, 5 months ago (2014-07-26 05:59:20 UTC) #4

Message was sent while issue was closed.

Change committed as 285801

Expand Messages | Collapse Messages