Source/core/html/HTMLOptionElement.cpp - Issue 418133003: Call insertedInto or removedFrom before childrenChanged

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLOptionElement.cpp

Issue 418133003: Call insertedInto or removedFrom before childrenChanged (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Fix option elements. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/HTMLOptionElement.cpp

diff --git a/Source/core/html/HTMLOptionElement.cpp b/Source/core/html/HTMLOptionElement.cpp

index cc17a25ab6c7a59828c51509c3c0ed19bdb7482d..a02a889367e73b3afbc50809de3ccd44a1c21b21 100644

--- a/Source/core/html/HTMLOptionElement.cpp

+++ b/Source/core/html/HTMLOptionElement.cpp

@@ -348,8 +348,10 @@ Node::InsertionNotificationRequest HTMLOptionElement::insertedInto(ContainerNode

void HTMLOptionElement::removedFrom(ContainerNode* insertionPoint)

{

- if (HTMLSelectElement* select = Traversal<HTMLSelectElement>::firstAncestorOrSelf(*insertionPoint))

+ if (HTMLSelectElement* select = Traversal<HTMLSelectElement>::firstAncestorOrSelf(*insertionPoint)) {

+ select->setRecalcListItems();

select->optionRemoved(*this);

+ }

HTMLElement::removedFrom(insertionPoint);

}

« no previous file with comments | « Source/core/dom/ContainerNode.cpp ('k') | no next file » | no next file with comments »