Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Side by Side Diff: Source/core/dom/ContainerNode.h

Issue 418133003: Call insertedInto or removedFrom before childrenChanged (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fix option elements. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007, 2009, 2010, 2011, 2013 Apple Inc. All r ights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007, 2009, 2010, 2011, 2013 Apple Inc. All r ights reserved.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 154 matching lines...) Expand 10 before | Expand all | Expand 10 after
165 }; 165 };
166 166
167 // Notifies the node that it's list of children have changed (either by addi ng or removing child nodes), or a child 167 // Notifies the node that it's list of children have changed (either by addi ng or removing child nodes), or a child
168 // node that is of the type CDATA_SECTION_NODE, TEXT_NODE or COMMENT_NODE ha s changed its value. 168 // node that is of the type CDATA_SECTION_NODE, TEXT_NODE or COMMENT_NODE ha s changed its value.
169 virtual void childrenChanged(const ChildrenChange&); 169 virtual void childrenChanged(const ChildrenChange&);
170 170
171 void disconnectDescendantFrames(); 171 void disconnectDescendantFrames();
172 172
173 virtual void trace(Visitor*) OVERRIDE; 173 virtual void trace(Visitor*) OVERRIDE;
174 174
175 void notifyNodeInserted(Node&); 175 void notifyNodeInserted(Node&, ChildrenChangeSource = ChildrenChangeSourceAP I);
176 void notifyNodeRemoved(Node&); 176 void notifyNodeRemoved(Node&);
177 177
178 protected: 178 protected:
179 ContainerNode(TreeScope*, ConstructionType = CreateContainer); 179 ContainerNode(TreeScope*, ConstructionType = CreateContainer);
180 180
181 #if !ENABLE(OILPAN) 181 #if !ENABLE(OILPAN)
182 void removeDetachedChildren(); 182 void removeDetachedChildren();
183 #endif 183 #endif
184 184
185 void setFirstChild(Node* child) { m_firstChild = child; } 185 void setFirstChild(Node* child) { m_firstChild = child; }
(...skipping 136 matching lines...) Expand 10 before | Expand all | Expand 10 after
322 inline void getChildNodes(Node& node, NodeVector& nodes) 322 inline void getChildNodes(Node& node, NodeVector& nodes)
323 { 323 {
324 ASSERT(!nodes.size()); 324 ASSERT(!nodes.size());
325 for (Node* child = node.firstChild(); child; child = child->nextSibling()) 325 for (Node* child = node.firstChild(); child; child = child->nextSibling())
326 nodes.append(child); 326 nodes.append(child);
327 } 327 }
328 328
329 } // namespace blink 329 } // namespace blink
330 330
331 #endif // ContainerNode_h 331 #endif // ContainerNode_h
OLDNEW
« no previous file with comments | « LayoutTests/fast/dom/script-remove-child-id-map-expected.txt ('k') | Source/core/dom/ContainerNode.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698