Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 418113003: Extract SourceControl to module; extract common methods to bisect_utils. (Closed)

Created:
6 years, 5 months ago by qyearsley
Modified:
6 years, 5 months ago
Reviewers:
prasadv, shatch
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Extract SourceControl to module; extract common methods to bisect_utils. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285639

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+522 lines, -496 lines) Patch
M tools/auto_bisect/bisect_utils.py View 2 chunks +155 lines, -0 lines 0 comments Download
A tools/auto_bisect/source_control.py View 1 chunk +287 lines, -0 lines 1 comment Download
M tools/bisect-perf-regression.py View 48 chunks +80 lines, -496 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
qyearsley
In this CL: Move the following things to their own module: class SourceControl class GitSourceControl ...
6 years, 5 months ago (2014-07-24 20:29:09 UTC) #1
shatch
lgtm https://codereview.chromium.org/418113003/diff/1/tools/auto_bisect/source_control.py File tools/auto_bisect/source_control.py (right): https://codereview.chromium.org/418113003/diff/1/tools/auto_bisect/source_control.py#newcode30 tools/auto_bisect/source_control.py:30: class SourceControl(object): Not for this CL, but probably ...
6 years, 5 months ago (2014-07-25 16:28:50 UTC) #2
prasadv
lgtm
6 years, 5 months ago (2014-07-25 17:40:25 UTC) #3
qyearsley
The CQ bit was checked by qyearsley@chromium.org
6 years, 5 months ago (2014-07-25 17:44:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qyearsley@chromium.org/418113003/1
6 years, 5 months ago (2014-07-25 17:46:38 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-25 19:03:50 UTC) #6
Message was sent while issue was closed.
Change committed as 285639

Powered by Google App Engine
This is Rietveld 408576698