Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issue 418103006: Ignore duplicate calls to safe browsing's last download finder SearchInProfile. (Closed)

Created:
6 years, 5 months ago by grt (UTC plus 2)
Modified:
6 years, 5 months ago
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Make safe browsing's last download finder's SearchInProfile idempotent. Different orderings of notifications could previously trip up the finder. They don't now. BUG=397229 R=shess@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285495

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M chrome/browser/safe_browsing/last_download_finder.cc View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
grt (UTC plus 2)
6 years, 5 months ago (2014-07-24 23:04:26 UTC) #1
grt (UTC plus 2)
Please hit CQ if it looks good to you.
6 years, 5 months ago (2014-07-24 23:05:52 UTC) #2
Scott Hess - ex-Googler
lgtm
6 years, 5 months ago (2014-07-25 01:14:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grt@chromium.org/418103006/1
6 years, 5 months ago (2014-07-25 01:17:16 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-25 05:54:46 UTC) #5
Message was sent while issue was closed.
Change committed as 285495

Powered by Google App Engine
This is Rietveld 408576698