Add a frame sequence number to HistoryItem

Source/core/loader/HistoryItem.h

 /*
  * Copyright (C) 2006, 2008, 2011 Apple Inc. All rights reserved.
  * Copyright (C) 2012 Research In Motion Limited. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 76 matching lines @@
 
     void setStateObject(PassRefPtr<SerializedScriptValue>);
     SerializedScriptValue* stateObject() const { return m_stateObject.get(); }
 
     void setItemSequenceNumber(long long number) { m_itemSequenceNumber = number; }
     long long itemSequenceNumber() const { return m_itemSequenceNumber; }
 
     void setDocumentSequenceNumber(long long number) { m_documentSequenceNumber = number; }
     long long documentSequenceNumber() const { return m_documentSequenceNumber; }
 
+    void setFrameSequenceNumber(long long number) { m_frameSequenceNumber = number; }
+    long long frameSequenceNumber() const { return m_frameSequenceNumber; }
+
     void setFormInfoFromRequest(const ResourceRequest&);
     void setFormData(PassRefPtr<FormData>);
     void setFormContentType(const AtomicString&);
 
     bool isCurrentDocument(Document*) const;
 
 private:
     HistoryItem();
 
     String m_urlString;
@@ skipping 10 matching lines @@
     // clones of one another. Traversing history from one such HistoryItem to
     // another is a no-op. HistoryItem clones are created for parent and
     // sibling frames when only a subframe navigates.
     int64_t m_itemSequenceNumber;
 
     // If two HistoryItems have the same document sequence number, then they
     // refer to the same instance of a document. Traversing history from one
     // such HistoryItem to another preserves the document.
     int64_t m_documentSequenceNumber;
 
+    // Used to match frames across serialization/deserialization more reliably

[darin (slow to review), 2014/07/25 04:39:06]

I think it would be more helpful to add a comment here that defines the new
field, similar to the definitions for the other sequence numbers. What does
frame sequence number represent? How does it evolve, etc.?

+    // than is possible using unique names.
+    int64_t m_frameSequenceNumber;
+
     // Support for HTML5 History
     RefPtr<SerializedScriptValue> m_stateObject;
 
     // info used to repost form data
     RefPtr<FormData> m_formData;
     AtomicString m_formContentType;
 
 }; // class HistoryItem
 
 } // namespace blink
 
 #endif // HISTORYITEM_H