Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(832)

Unified Diff: src/trusted/service_runtime/sel_ldr.c

Issue 4181005: Fixes some bugs with memory setup and halt-sled allocation and... (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client/
Patch Set: '' Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/trusted/service_runtime/nacl_text.c ('k') | src/trusted/service_runtime/sel_ldr_standard.c » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/trusted/service_runtime/sel_ldr.c
===================================================================
--- src/trusted/service_runtime/sel_ldr.c (revision 3633)
+++ src/trusted/service_runtime/sel_ldr.c (working copy)
@@ -361,6 +361,10 @@
entry->page_num, entry->page_num);
gprintf(gp, "npages %"NACL_PRIdS" (0x%"NACL_PRIxS")\n", entry->npages,
entry->npages);
+ gprintf(gp, "start vaddr 0x%"NACL_PRIxPTR"\n",
+ entry->page_num << NACL_PAGESHIFT);
+ gprintf(gp, "end vaddr 0x%"NACL_PRIxPTR"\n",
+ (entry->page_num + entry->npages) << NACL_PAGESHIFT);
gprintf(gp, "prot 0x%08x\n", entry->prot);
gprintf(gp, "%sshared/backed by a file\n",
(NULL == entry->nmop) ? "not " : "");
@@ -466,6 +470,10 @@
return "Text segment overlaps rodata segment";
case LOAD_TEXT_OVERLAPS_DATA:
return "No rodata segment, and text segment overlaps data segment";
+ case LOAD_BAD_RODATA_ALIGNMENT:
+ return "The rodata segment is not properly aligned";
+ case LOAD_BAD_DATA_ALIGNMENT:
+ return "The data segment is not properly aligned";
case LOAD_UNLOADABLE:
return "Error during loading";
case LOAD_BAD_ELF_TEXT:
« no previous file with comments | « src/trusted/service_runtime/nacl_text.c ('k') | src/trusted/service_runtime/sel_ldr_standard.c » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698