Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Unified Diff: content/browser/web_contents/web_contents_impl.cc

Issue 418093005: Do not save and restore View focus on aura::Window focus changes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Focus the dialog's views::WebView when its content::WebContents is focused. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/web_contents/web_contents_impl.cc
diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc
index 0471f0bc36e3c7fa8c619e0a01e04e2915c96243..2a21f44e28191b1b56eeadcb13f1aff794f212bc 100644
--- a/content/browser/web_contents/web_contents_impl.cc
+++ b/content/browser/web_contents/web_contents_impl.cc
@@ -2002,6 +2002,8 @@ void WebContentsImpl::Focus() {
fullscreen_view->Focus();
else
view_->Focus();
+
+ FOR_EACH_OBSERVER(WebContentsObserver, observers_, WasFocused());
Ben Goodger (Google) 2014/07/30 02:57:26 So you should be able to trigger this off of the F
msw 2014/07/30 03:18:12 I'll look into this, but the WebView doesn't get F
Ben Goodger (Google) 2014/07/30 15:44:02 Not the WebView... view_->Focus() sets focus to an
}
void WebContentsImpl::SetInitialFocus() {
« no previous file with comments | « chrome/browser/ui/views/constrained_web_dialog_delegate_views.cc ('k') | content/public/browser/web_contents_observer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698