Factored out duplicate code for formatting full test name

base/test/launcher/test_launcher.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/test/launcher/test_launcher.h"
 
 #if defined(OS_POSIX)
 #include <fcntl.h>
 #endif
 
@@ skipping 560 matching lines @@
 
   fprintf(stdout, "Retrying %" PRIuS " test%s (retry #%" PRIuS ")\n",
           retry_started_count,
           retry_started_count > 1 ? "s" : "",
           retry_count_);
   fflush(stdout);
 
   test_started_count_ += retry_started_count;
 }
 
+std::string TestLauncher::FormatFullTestName(const std::string& test_case_name,

[sky, 2014/07/31 15:57:22]

Add // static on previous line (see style guide).

[Sergiy Byelozyorov, 2014/07/31 17:33:03]

Done.

+                                             const std::string& test_name) {
+  return test_case_name + "." + test_name;
+}
+
 bool TestLauncher::Init() {
   const CommandLine* command_line = CommandLine::ForCurrentProcess();
 
   // Initialize sharding. Command line takes precedence over legacy environment
   // variables.
   if (command_line->HasSwitch(switches::kTestLauncherTotalShards) &&
       command_line->HasSwitch(switches::kTestLauncherShardIndex)) {
     if (!StringToInt(
             command_line->GetSwitchValueASCII(
                 switches::kTestLauncherTotalShards),
@@ skipping 189 matching lines @@
 
 void TestLauncher::RunTests() {
   testing::UnitTest* const unit_test = testing::UnitTest::GetInstance();
 
   std::vector<std::string> test_names;
 
   for (int i = 0; i < unit_test->total_test_case_count(); ++i) {
     const testing::TestCase* test_case = unit_test->GetTestCase(i);
     for (int j = 0; j < test_case->total_test_count(); ++j) {
       const testing::TestInfo* test_info = test_case->GetTestInfo(j);
-      std::string test_name = test_info->test_case_name();
-      test_name.append(".");
-      test_name.append(test_info->name());
+      std::string test_name = FormatFullTestName(
+          test_info->test_case_name(), test_name.append(test_info->name()));
 
       results_tracker_.AddTest(test_name);
 
       const CommandLine* command_line = CommandLine::ForCurrentProcess();
       if (test_name.find("DISABLED") != std::string::npos) {
         results_tracker_.AddDisabledTest(test_name);
 
         // Skip disabled tests unless explicitly requested.
         if (!command_line->HasSwitch(kGTestRunDisabledTestsFlag))
           continue;
@@ skipping 288 matching lines @@
 
     g_live_processes.Get().erase(process_handle);
   }
 
   base::CloseProcessHandle(process_handle);
 
   return exit_code;
 }
 
 }  // namespace base