Issue 418053004: Fix CvoxBrailleUtilUnitTest.TextFieldSelection

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 418053004: Fix CvoxBrailleUtilUnitTest.TextFieldSelection (Closed)

Created:
6 years, 5 months ago by dmazzoni

Modified:
6 years, 5 months ago

Reviewers:
Alexei Svitkine (slow), David Tseng

CC:
chromium-reviews, oshima+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nkostylev+watch_chromium.org, yuzo+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, stevenjb+watch_chromium.org, arv+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Fix CvoxBrailleUtilUnitTest.TextFieldSelection It was assuming that modifying selectionStart/selectionEnd on an input element focused the element, but Blink just changed to remove that behavior. Fixed by explicitly focusing the element. BUG=397212, 393504 R=asvitkine@chromium.org TBR=dtseng Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285344

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	chrome/browser/resources/chromeos/chromevox/common/braille_util_test.js	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

dmazzoni

6 years, 5 months ago (2014-07-24 18:58:36 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r285344 (presubmit successful).

Expand Messages | Collapse Messages