chrome/browser/ui/sync/one_click_signin_sync_starter.cc - Issue 418043002: Add test for showing confirmation dialog for unsecure signin

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/sync/one_click_signin_sync_starter.cc

Issue 418043002: Add test for showing confirmation dialog for unsecure signin (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: trybot errors fixed Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/sync/one_click_signin_sync_starter.cc

diff --git a/chrome/browser/ui/sync/one_click_signin_sync_starter.cc b/chrome/browser/ui/sync/one_click_signin_sync_starter.cc

index 157d23b4dcf3204d6457285646d3bedeba4fd7f9..f4c7b3eaf15acb892aae5c7b8b42bd7cae90f1bb 100644

--- a/chrome/browser/ui/sync/one_click_signin_sync_starter.cc

+++ b/chrome/browser/ui/sync/one_click_signin_sync_starter.cc

@@ -382,6 +382,7 @@ void OneClickSigninSyncStarter::ConfirmAndSignin() {

base::string16(), // No error message to display.

base::Bind(&OneClickSigninSyncStarter::UntrustedSigninConfirmed,

weak_pointer_factory_.GetWeakPtr()));

+ LoginUIServiceFactory::GetForProfile(profile_)->UntrustedLoginUIShown();

} else {

// No confirmation required - just sign in the user.

signin->CompletePendingSignin();