Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1666)

Unified Diff: chrome/browser/chromeos/login/saml/saml_browsertest.cc

Issue 418043002: Add test for showing confirmation dialog for unsecure signin (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/saml/saml_browsertest.cc
diff --git a/chrome/browser/chromeos/login/saml/saml_browsertest.cc b/chrome/browser/chromeos/login/saml/saml_browsertest.cc
index 309f8a89b48c988537e2598ecefb8b54fb1f4783..551b15cd031770833e5c5c4b8f3e2fbed90557f9 100644
--- a/chrome/browser/chromeos/login/saml/saml_browsertest.cc
+++ b/chrome/browser/chromeos/login/saml/saml_browsertest.cc
@@ -57,15 +57,6 @@ namespace chromeos {
namespace {
-const char kTestAuthSIDCookie[] = "fake-auth-SID-cookie";
-const char kTestAuthLSIDCookie[] = "fake-auth-LSID-cookie";
-const char kTestAuthCode[] = "fake-auth-code";
-const char kTestGaiaUberToken[] = "fake-uber-token";
-const char kTestAuthLoginAccessToken[] = "fake-access-token";
-const char kTestRefreshToken[] = "fake-refresh-token";
-const char kTestSessionSIDCookie[] = "fake-session-SID-cookie";
-const char kTestSessionLSIDCookie[] = "fake-session-LSID-cookie";
-
const char kFirstSAMLUserEmail[] = "bob@example.com";
const char kSecondSAMLUserEmail[] = "alice@example.com";
const char kHTTPSAMLUserEmail[] = "carol@example.com";
@@ -256,7 +247,7 @@ class SamlTest : public InProcessBrowserTest {
}
virtual void SetUpOnMainThread() OVERRIDE {
- SetMergeSessionParams(kFirstSAMLUserEmail);
+ fake_gaia_.SetFakeMergeSessionParamsForEmail(kFirstSAMLUserEmail);
embedded_test_server()->RegisterRequestHandler(
base::Bind(&FakeGaia::HandleRequest, base::Unretained(&fake_gaia_)));
@@ -280,20 +271,6 @@ class SamlTest : public InProcessBrowserTest {
}
}
- void SetMergeSessionParams(const std::string& email) {
- FakeGaia::MergeSessionParams params;
- params.auth_sid_cookie = kTestAuthSIDCookie;
- params.auth_lsid_cookie = kTestAuthLSIDCookie;
- params.auth_code = kTestAuthCode;
- params.refresh_token = kTestRefreshToken;
- params.access_token = kTestAuthLoginAccessToken;
- params.gaia_uber_token = kTestGaiaUberToken;
- params.session_sid_cookie = kTestSessionSIDCookie;
- params.session_lsid_cookie = kTestSessionLSIDCookie;
- params.email = email;
- fake_gaia_.SetMergeSessionParams(params);
- }
-
WebUILoginDisplay* GetLoginDisplay() {
ExistingUserController* controller =
ExistingUserController::current_controller();
@@ -394,9 +371,9 @@ class SamlTest : public InProcessBrowserTest {
protected:
scoped_ptr<content::WindowedNotificationObserver> login_screen_load_observer_;
+ FakeGaia fake_gaia_;
private:
- FakeGaia fake_gaia_;
FakeSamlIdp fake_saml_idp_;
scoped_ptr<HTTPSForwarder> gaia_https_forwarder_;
scoped_ptr<HTTPSForwarder> saml_https_forwarder_;
@@ -517,7 +494,7 @@ IN_PROC_BROWSER_TEST_F(SamlTest, UseAutenticatedUserEmailAddress) {
// Authenticate as alice@example.com via SAML (the |Email| provided here is
// irrelevant - the authenticated user's e-mail address that FakeGAIA
- // reports was set via SetMergeSessionParams()).
+ // reports was set via |SetFakeMergeSessionParamsForEmail|.
SetSignFormField("Email", "fake_user");
SetSignFormField("Password", "fake_password");
ExecuteJsInSigninFrame("document.getElementById('Submit').click();");
@@ -539,7 +516,7 @@ IN_PROC_BROWSER_TEST_F(SamlTest, FailToRetrieveAutenticatedUserEmailAddress) {
fake_saml_idp()->SetLoginHTMLTemplate("saml_login.html");
StartSamlAndWaitForIdpPageLoad(kFirstSAMLUserEmail);
- SetMergeSessionParams("");
+ fake_gaia_.SetFakeMergeSessionParamsForEmail("");
SetSignFormField("Email", "fake_user");
SetSignFormField("Password", "fake_password");
ExecuteJsInSigninFrame("document.getElementById('Submit').click();");

Powered by Google App Engine
This is Rietveld 408576698