Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Unified Diff: chrome/browser/ui/webui/signin/inline_login_handler_impl.cc

Issue 418043002: Add test for showing confirmation dialog for unsecure signin (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/signin/inline_login_handler_impl.cc
diff --git a/chrome/browser/ui/webui/signin/inline_login_handler_impl.cc b/chrome/browser/ui/webui/signin/inline_login_handler_impl.cc
index 38b928e2caa4931567509f3fefaacf680b849eaf..a1bb0bc1f3bae38d0da9c7decd4362c67941489c 100644
--- a/chrome/browser/ui/webui/signin/inline_login_handler_impl.cc
+++ b/chrome/browser/ui/webui/signin/inline_login_handler_impl.cc
@@ -244,11 +244,13 @@ void InlineLoginHandlerImpl::DidCommitProvisionalLoadForFrame(
// Loading any untrusted (e.g., HTTP) URLs in the privileged sign-in process
// will require confirmation before the sign in takes effect.
- if (!url.is_empty() &&
- url.spec() != url::kAboutBlankURL &&
- !gaia::IsGaiaSignonRealm(url.GetOrigin()) &&
- !signin::IsContinueUrlForWebBasedSigninFlow(url)) {
- confirm_untrusted_signin_ = true;
+ if (!url.is_empty()) {
+ GURL origin(url.GetOrigin());
+ if (url.spec() != url::kAboutBlankURL &&
+ origin != kGaiaExtOrigin &&
+ !gaia::IsGaiaSignonRealm(origin)) {
+ confirm_untrusted_signin_ = true;
+ }
}
}

Powered by Google App Engine
This is Rietveld 408576698